areusch commented on pull request #8382: URL: https://github.com/apache/tvm/pull/8382#issuecomment-895341780
@mikepapadim @tqchen @junrushao1994 i'd still like us to use the `ci-lint` image to invoke each of these checks. doing this will ensure that the output of the pre-commit hook exactly matches the CI (or has the best chance of doing so). the best way to do this is with: `docker/lint.sh <check_name>` there is one wrinkle with this approach--it will fail spectacularly when you are inside a `git-worktree` other than your original git repo. @Lunderberg is resolving this limitation with #8670. do you mind changing the command line to `docker/lint.sh` for the pre-commit steps? then i'm good with merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
