YuchenJin commented on pull request #8706: URL: https://github.com/apache/tvm/pull/8706#issuecomment-897293483
Hi @ganler, Overall LGTM! Thanks for elaborating on the issue and implementing the fix! One question is that whether we want to also make `assert tir.const(1, "uint2") == tir.const(1, "int2")` work? I think since `lhs` and `rhs` have the same bits, `SimpleCast` will be applied to both sides, but the same error throws. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
