guberti commented on a change in pull request #8708: URL: https://github.com/apache/tvm/pull/8708#discussion_r687982552
########## File path: apps/microtvm/arduino/host_driven/src/standalone_crt/crt_config/crt_config.h ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/runtime/crt/host/crt_config.h + * \brief CRT configuration for the host-linked CRT. + */ +#ifndef TVM_RUNTIME_MICRO_CRT_CONFIG_H_ Review comment: Agreed, the path that was there before is wrong. However, I'm not sure if changing it to `apps/microtvm/arduino/host_driven/src/standalone_crt/crt_config/crt_config.h` makes sense, since that file exists only to be templated into an Arduino project. I just removed the `\file` line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
