Mousius commented on a change in pull request #8768:
URL: https://github.com/apache/tvm/pull/8768#discussion_r692033127
##########
File path: include/tvm/ir/type.h
##########
@@ -164,10 +164,17 @@ class PointerTypeNode : public TypeNode {
}
bool SEqualReduce(const PointerTypeNode* other, SEqualReducer equal) const {
- return equal(element_type, other->element_type);
+ // Make "global" equal to ""
+ String lhs_scope = storage_scope.empty() ? "global" : storage_scope;
Review comment:
Thanks @Hzfengsy, this makes it a lot clearer! This is likely due to
some mismatch of the default `scope` in `Stage` - I did a quick experiment in
setting the default `scope` to `"global"` in the `Stage` constructor
(https://github.com/apache/tvm/blob/main/src/te/schedule/schedule_lang.cc#L92)
and this revealed more places within the TE tests which fail.
I'd propose we have two options:
1. Change the defaults to `"global"` as far as we can here and raise an
issue for updating TE / `Stage` with the recreation steps you've illustrated -
given it overwrites the `scope` in the TE `Stage` to `""` it seems reasonably
self-contained.
2. Commit the workaround that's been proposed already and raise an issue for
updating everything to default to `"global"` in one move.
@Hzfengsy / @tqchen what do you think of these options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
