Lyken17 opened a new pull request #8799: URL: https://github.com/apache/tvm/pull/8799
As mentioned in https://github.com/apache/tvm/issues/8182, `TranposedConv2d` is an important operator in GAN related applications and `groups` should also be supported for this operator. This PR was set to implement this missing feature. However, there are parts I am still confusing * Which names should be used for the topi function? In topi.nn.conv2d, there are `data, kernel, strides, padding, out_dtype, output_padding` as well as `Input, Filter, strides, padding, out_dtype, output_padding`, which one should be used for newly added function? * Should we add a new function, or extend existing ones? In most DL frameoworks (e.g., PyTorch), `conv2d` is a unified function with support of various arguments such as padding, dilation, groups. But in `topi`, `conv2d` (w/o groups) and `group_conv2d` are two differnet function. While I understand this might be important to backward compability, I would recommend to merge these functions for simplicty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
