mbs-octoml commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905810621
I'm fine with 1, and in the future: 4. Ensure all Targets are created at the top level and shared throughout the code rather than created on-the-fly for various 'default' or 'cpu only' situations. Implementing structural equality and hash for Targets (and GlobalVars while we're at it!) is sensible and we can leave them in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
