Mousius commented on a change in pull request #8856:
URL: https://github.com/apache/tvm/pull/8856#discussion_r696734145
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -84,10 +84,7 @@ class AOTOnDemandAllocator : public ExprVisitor {
AssignReturnSid(GetRef<Expr>(op));
}
- void VisitExpr_(const VarNode* op) final {
- ExprVisitor::VisitExpr_(op);
- AssignReturnSid(GetRef<Expr>(op));
- }
+ void VisitExpr_(const VarNode* op) final {
AssignReturnSid(GetRef<Expr>(op)); }
Review comment:
To further add to the mystery, here's what `ExprVisitor::VisitExpr` does:
```
void ExprVisitor::VisitExpr_(const VarNode* op) {
this->VisitSpan(op->span);
if (op->type_annotation.defined()) {
this->VisitType(op->type_annotation);
}
}
```
which calls into:
```
void ExprVisitor::VisitType(const Type& t) { return; }
void ExprVisitor::VisitSpan(const Span& span) { return; }
```
neither of which seem to be overridden by AOT, so I think this did nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
