[tvm] branch main updated: [Hexagon] Don't use {} initialization with FastRPC structures (#9033)

[moreau]

This is an automated email from the ASF dual-hosted git repository.

moreau pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git


The following commit(s) were added to refs/heads/main by this push:
     new 1fd8f61  [Hexagon] Don't use {} initialization with FastRPC structures 
(#9033)
1fd8f61 is described below

commit 1fd8f610953adc39cbd18d82f4a9e92a11575dfc
Author: Krzysztof Parzyszek <kparz...@quicinc.com>
AuthorDate: Thu Sep 16 22:08:26 2021 -0500

    [Hexagon] Don't use {} initialization with FastRPC structures (#9033)
    
    The data members in FastRPC structures aren't guaranteed to remain
    in the same order. Replace aggregate initialization with direct,
    member-by-member initialization.
---
 src/runtime/hexagon/launcher/launcher_android.cc | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/runtime/hexagon/launcher/launcher_android.cc 
b/src/runtime/hexagon/launcher/launcher_android.cc
index c0e428c..008e4fd 100644
--- a/src/runtime/hexagon/launcher/launcher_android.cc
+++ b/src/runtime/hexagon/launcher/launcher_android.cc
@@ -32,7 +32,9 @@
 #include "launcher_rpc.h"
 
 AEEResult enable_unsigned_pd(bool enable) {
-  remote_rpc_control_unsigned_module data{static_cast<int>(enable), 
CDSP_DOMAIN_ID};
+  remote_rpc_control_unsigned_module data;
+  data.domain = CDSP_DOMAIN_ID;
+  data.enable = static_cast<int>(enable);
   AEEResult rc = remote_session_control(DSPRPC_CONTROL_UNSIGNED_MODULE, &data, 
sizeof(data));
   if (rc != AEE_SUCCESS) {
     std::cout << "error " << (enable ? "enabling" : "disabling") << " unsigned 
PD\n";
@@ -41,8 +43,11 @@ AEEResult enable_unsigned_pd(bool enable) {
 }
 
 AEEResult set_remote_stack_size(int size) {
-  remote_rpc_thread_params th_data{CDSP_DOMAIN_ID, -1, size};
-  AEEResult rc = remote_session_control(FASTRPC_THREAD_PARAMS, &th_data, 
sizeof(th_data));
+  remote_rpc_thread_params data;
+  data.domain = CDSP_DOMAIN_ID;
+  data.prio = -1;
+  data.stack_size = size;
+  AEEResult rc = remote_session_control(FASTRPC_THREAD_PARAMS, &data, 
sizeof(data));
   if (rc != AEE_SUCCESS) {
     std::cout << "error setting remote stack size: " << std::hex << rc << '\n';
   }