mbs-octoml commented on pull request #29: URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-924299473
+1 overall. We've been thinking along the same lines for replacing the explicit TargetMap (and it's convention for designating the 'default' target) and the 'host target' + 'device target' convention with a single datastructure describing all the targets which are significant for compilation and which are to be used as defaults for the different situations (for shape computation, for residual loops after offloading to prims, for generic relay computation). I'm trying to write that up as an RFC and will ping y'all asap. I'm 80% on the just-put-it-in-the-IRModule camp since that is the one datastructure we are already threading all the way through. But we also make very heavy use of implicit global stacks (eg pass contexts), as well as pass-everywhere arguments (eg existing targets, target pairs and target maps). Perhaps that's the only contentious thing we need to resolve here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
