PhilippvK commented on issue #8953: URL: https://github.com/apache/tvm/issues/8953#issuecomment-940589338
> So it seems like the "correct" thing to do is to define TVM_CRT_MAX_STRLEN_PARAM_NAME, replace the current usages of TVM_CRT_MAX_STRLEN_FUNCTION_NAME with TVM_CRT_MAX_STRLEN_PARAM_NAME, and then fix up any residual [120] to be TVM_CRT_MAX_STRLEN_FUNCTION_NAME. sorry this is a bit more involved than originally anticipated... @areusch thanks for clearing things up. I should no be able to get rid of these inconsistencies in a PR. What would be a suitable value for `TVM_CRT_MAX_STRLEN_PARAM_NAME`? I mean, will they always be of the form `p35,p36,...` or would there be a good reason to have more than lets say `10` characters available for a single parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
