shingjan commented on a change in pull request #9432:
URL: https://github.com/apache/tvm/pull/9432#discussion_r742315159
##########
File path: mypy.ini
##########
@@ -23,6 +23,14 @@ follow_imports = skip
ignore_errors = False
strict_optional = False
+#
+# Note: not all tests under .tests/ are typed
+# Therefore include test files that should be
+# checked by mypy here
+#
+files =
+ tests/python/unittest/test_tvmscript_type.py
Review comment:
Good point. The reason why I include that test in `mypy.ini` is that
PyTorch seems to add individual test to mypy this
[way](https://github.com/pytorch/pytorch/blob/master/mypy.ini). But adding that
to `task_mypy.sh` should also work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
