cconvey commented on a change in pull request #9473:
URL: https://github.com/apache/tvm/pull/9473#discussion_r745782263
##########
File path: tests/python/contrib/test_hexagon/infrastructure.py
##########
@@ -18,36 +18,43 @@
""" Hexagon testing infrastructure """
import tvm
+from tvm import te
import numpy
def ceildiv(o, d):
return tvm.tir.floordiv(o + d - 1, d)
Review comment:
Should we add a comment that this function might only work as intended
for _positive_ numbers?
tl;dr:
It's not obvious if this has intuitive behavior when `o` and/or `d` are
negative. AFAIK `o` and `d` will only be positive when we're calling this, but
someone might decide to promote this function to a broader role in TVM.
##########
File path: tests/python/contrib/test_hexagon/infrastructure.py
##########
@@ -18,36 +18,43 @@
""" Hexagon testing infrastructure """
import tvm
+from tvm import te
import numpy
def ceildiv(o, d):
return tvm.tir.floordiv(o + d - 1, d)
-def get_packed_activation_layout(shape_nhwc, block_shape, packed_C=True):
+def get_block_shape():
+ return 8, 8, 32
+
+
+def get_filter_block_shape():
+ return 8, 32, 4
Review comment:
It's not obvious why these particular numbers are chosen. Should there
be comments explaining the reasons for using them?
##########
File path: tests/python/contrib/test_hexagon/infrastructure.py
##########
@@ -18,36 +18,43 @@
""" Hexagon testing infrastructure """
import tvm
+from tvm import te
import numpy
def ceildiv(o, d):
return tvm.tir.floordiv(o + d - 1, d)
-def get_packed_activation_layout(shape_nhwc, block_shape, packed_C=True):
+def get_block_shape():
+ return 8, 8, 32
+
+
+def get_filter_block_shape():
+ return 8, 32, 4
+
+
+def get_packed_shape(shape_nhwc):
Review comment:
Since we have several competing versions of "shape" in this code, would
it be helpful (for clarity) to rename `shape_nhwc` to `logical_shape_nhwc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
