gromero commented on a change in pull request #9472:
URL: https://github.com/apache/tvm/pull/9472#discussion_r745949453
##########
File path: version.py
##########
@@ -31,17 +31,15 @@
import logging
import subprocess
-# Modify the following two settings during release
+# Modify the following value during release
# ---------------------------------------------------
# Current version
# We use the version of the incoming release for code
-# that is under development
+# that is under development. It is also fallback version
Review comment:
Maybe change "It is also..." to something like "Version below will be
used as a fallback version when the version can't be determined via 'git
describe"?
##########
File path: version.py
##########
@@ -80,7 +78,7 @@ def git_describe_version():
after the most recent tag(v0.7.0),
the git short hash tag of the current commit is 0d07a329e.
"""
- cmd = ["git", "describe", "--tags", "--match", "v[0-9]*.[0-9]*.[0-9]*"]
+ cmd = ["git", "describe", "--tags", "--match", "v[0-9]*.[0-9]*.[dev0-9]*"]
Review comment:
The glob pattern here matches also, for instance, `v0.7.ev0`, because
`dev` is not treated as a string, but as a char set. If both exact tags (like
v0.7.0) and dev tags must be matched I think there is not way to do that
besides adding a `--match "v[0-9]*.[0-9]*.dev[0-9]*"` after the exiting
`--match`, since multiple `--match` are accumulated. I'm a tad surprised git is
not using something more powerful (regex) for these patterns... : /
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
