areusch commented on a change in pull request #9229:
URL: https://github.com/apache/tvm/pull/9229#discussion_r748590164
##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -109,21 +168,58 @@ def drive_run(args):
Arguments from command line parser.
"""
- rpc_hostname, rpc_port =
common.tracker_host_port_from_cli(args.rpc_tracker)
+ path = pathlib.Path(args.PATH)
+ options = None
+ if args.device == "micro":
+ path = path / "model.tar"
Review comment:
we can fix this in a follow-on, but i think this should be read from
ServerInfo.model_library_format_path. sorry for missing that before.
##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -366,79 +464,102 @@ def run_module(
"Try calling tvmc.compile on the model before running it."
)
- # Currently only two package formats are supported: "classic" and
- # "mlf". The later can only be used for micro targets, i.e. with microTVM.
- if tvmc_package.type == "mlf":
Review comment:
can also do this in a follow-on. i think you still need to preserve this
check when device != "micro"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
