Lunderberg commented on a change in pull request #9727:
URL: https://github.com/apache/tvm/pull/9727#discussion_r770649373
##########
File path: src/te/schedule/schedule_ops.cc
##########
@@ -343,12 +367,16 @@ Stmt ScheduleOps(Schedule sch, Map<IterVar, Range>
dom_map_, bool debug_keep_tri
Stage s = sch->stages[i - 1];
ICHECK_NE(s->attach_type, kInline) << "call schedule.normalize before
scheduleops";
ICHECK(s->op.defined());
- // no need to specify place holder op.
- if (s->op.as<PlaceholderOpNode>()) continue;
// Remove grouping sugar, get the real attach spec.
Stage attach_spec = s.GetAttachSpec();
- if (scan_init.count(s->op)) {
+ if (s->op.as<PlaceholderOpNode>()) {
+ // Placeholders don't need any realize/provide statements, but
+ // may be annotated with set_physical_layout to indicate the
+ // physical layout of an input, and must still have the
+ // attribute given.
+ body = WrapPhysicalLayout(s, std::move(body));
Review comment:
Thank you, and renamed to `WrapLayoutTransformationAttrs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
