comaniac commented on a change in pull request #9849:
URL: https://github.com/apache/tvm/pull/9849#discussion_r779362293
##########
File path: python/tvm/relay/transform/mixed_precision.py
##########
@@ -88,13 +89,19 @@
"min",
"maximum",
"minimum",
+ "argmax",
+ "argmin",
"nn.relu",
"nn.leaky_relu",
"nn.prelu",
"nn.dropout",
# Complicated activations which saturate in a narrow range
"sigmoid",
"tanh",
+ "fast_tanh", # Some coefficients outside of representable range, but
probably ok
+ "fast_exp",
+ "fast_erf",
+ "clip", # Usually safe, my result in oddity if clip greater than fp16
range
Review comment:
```suggestion
"clip", # Usually safe, may result in oddity if clip greater than fp16
range
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
