kparzysz-quic commented on a change in pull request #9950:
URL: https://github.com/apache/tvm/pull/9950#discussion_r787826081
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -127,7 +134,7 @@ class BuiltinLower : public StmtExprMutator {
auto storage_scope =
Downcast<PointerType>(op->buffer_var->type_annotation)->storage_scope;
if (dev_type->value == kDLCPU && storage_scope == "global") {
int32_t constant_size = op->constant_allocation_size();
- if (constant_size > 0 && constant_size * nbytes <
runtime::kMaxStackAlloca) {
+ if (constant_size > 0 && constant_size * nbytes < kMaxStackAlloca) {
Review comment:
Maybe you could also change the `<` to `<=`. Intuitively, an allocation
of size `kMaxStackAlloca` should still be allowed on the stack, but the `<`
would prevent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
