pfk-beta opened a new pull request #10255:
URL: https://github.com/apache/tvm/pull/10255


   Hello,
   This PR solves issue 10240. Previous implementation for checking device was 
little misleading/problematic. It was checking device in almost infinite loop 
(`while not dev.exist`), but the thread which was doing this was set with 
timeout. Check status was equivalent to thread state, imho it's incorrect and 
misleading.
   
   So I have changed to more proper way, but with little duplicated code:
   1. Still we have almost infinite loop (`while not dev.exist`)
   2. After loop finish we do not check thread status, but again check device
   3. I have added extra debug logging - leave or remove it - decision for 
owners of the project :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to