jtuyls commented on pull request #10084: URL: https://github.com/apache/tvm/pull/10084#issuecomment-1041558651
> @jtuyls @anilmartha, in the process of updating TF to 2.6 we (@ophirfrish @Mousius and me) bumped into an issue that `cpptests` were crashing, which turns out to be some conflicting `h5py` (versions `2.x` and `3.x`) installations in some Vitis related scripts. We are proposing to unify the `h5py` installation to be done only in the TF script. > > Can you please review and in case you disagree, propose some options to those changes? @leandron Could we keep the h5py being installed separately in the vitis_ai_core.sh script: https://github.com/apache/tvm/pull/10084/files#diff-7773869aa5e34502bbaa476fe3339c2e3956199b0be759084feee12fe8bcdfe1L37? In our Dockerfile we don't use the ubuntu_install_tensorflow.sh script so h5py won't be installed otherwise. This shouldn't affect the CI as this script is not used there. The changes in vitis_ai_packages_ci script are fine for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
