jacobbohlin commented on a change in pull request #10075:
URL: https://github.com/apache/tvm/pull/10075#discussion_r813798327
##########
File path: python/tvm/relay/backend/contrib/ethosu/legalize.py
##########
@@ -35,6 +35,40 @@
from tvm.relay.op.contrib import ethosu as ethosu_patterns # type: ignore
+def legalize_pass(
+ rewriter_cls: DFPatternCallback, name: Optional[str] = "", opt_level:
Optional[int] = 1
Review comment:
```suggestion
rewriter_cls: DFPatternCallback, name: str = "", opt_level: int = 1
```
I think this is an incorrect usage of Optional, as far as I can tell the
arguments will always be `str` and `int` but have default values if they are
not given.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
