Lunderberg opened a new pull request #10786: URL: https://github.com/apache/tvm/pull/10786
- Added device validity check in allocation. HexagonDeviceAPI should only be called for CPU/Hexagon types. - Check for "global.vtcm" scope instead of "vtcm". The ccope of N-d allocations produced by `LowerVtcmAlloc` should be `"global.vtcm"`. The previous check allowed unsupported scope such as `"local.vtcm"`. - Remove `vtcmallocs` entry after calling free. Previously, the vtcm allocation map kept dangling pointers to `HexagonBuffer` objects after they had been freed. - Rename N-d alloc and free packed functions. Since most of the similar device functions use snake case, renaming `*.AllocND` to `*.alloc_nd` and `*.FreeND` to `*.free_nd`. Co-authored-by: Adam Straw <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
