driazati commented on code in PR #11380:
URL: https://github.com/apache/tvm/pull/11380#discussion_r878530550
##########
jenkins/Jenkinsfile.j2:
##########
@@ -407,503 +99,29 @@ def make(docker_type, path, make_flag) {
{% set microtvm_template_projects = ['build/microtvm_template_projects',] %}
s3_prefix =
"tvm-jenkins-artifacts-prod/tvm/${env.BRANCH_NAME}/${env.BUILD_NUMBER}"
+// General note: Jenkins has limits on the size of a method (or top level code)
+// that are pretty strict, so most usage of groovy methods in these templates
+// are purely to satisfy the JVM
+{% include "jenkins/Prepare.groovy.j2" %}
Review Comment:
this is a template file, not a generated one (`.j2` == Jinja2), it get used
in the same way as the main jenkinsfile, `include` just means copy in the
contents after running it through the template enginge:
```bash
python jenkins/generate.py
```
all the paths in the templates are relative to the repo root though due to
how that script calls Jinja2:
https://github.com/apache/tvm/blob/85e42b6af38ea3bd0c99c8208d7baed5086a8959/jenkins/generate.py#L89
##########
jenkins/Jenkinsfile.j2:
##########
@@ -407,503 +99,29 @@ def make(docker_type, path, make_flag) {
{% set microtvm_template_projects = ['build/microtvm_template_projects',] %}
s3_prefix =
"tvm-jenkins-artifacts-prod/tvm/${env.BRANCH_NAME}/${env.BUILD_NUMBER}"
+// General note: Jenkins has limits on the size of a method (or top level code)
+// that are pretty strict, so most usage of groovy methods in these templates
+// are purely to satisfy the JVM
+{% include "jenkins/Prepare.groovy.j2" %}
Review Comment:
this is a template file, not a generated one (`.j2` == Jinja2), it get used
in the same way as the main jenkinsfile, `include` just means copy in the
contents after running it through the template engine:
```bash
python jenkins/generate.py
```
all the paths in the templates are relative to the repo root though due to
how that script calls Jinja2:
https://github.com/apache/tvm/blob/85e42b6af38ea3bd0c99c8208d7baed5086a8959/jenkins/generate.py#L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
