echuraev commented on PR #11488: URL: https://github.com/apache/tvm/pull/11488#issuecomment-1140182750
@mhyang-pllab thank you for your reply. I agree with you that the existing test will fail in the CI without your fix. My comment about the test is minor, and shouldn't really affect on the merging of this PR (I already approved this PR). But I think that we could add a tiny test with one select operator and different data types, I think that `float` and `int` will be enough. But once again, the comment about the test is minor. Please make CI green. @masahi this PR is LGTM. Please take a look at it and if you agree that we could merge it without a new test, then let's merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
