areusch commented on code in PR #11470: URL: https://github.com/apache/tvm/pull/11470#discussion_r886077532
########## docker/Dockerfile.ci_i386: ########## @@ -20,7 +20,9 @@ FROM i386/ubuntu:18.04 -RUN apt-get update --fix-missing && apt-get install -y ca-certificates +RUN apt-get update --fix-missing \ + && apt-get install -y ca-certificates \ + && rm -rf /var/cache/apt/archives /var/lib/apt/lists/* Review Comment: could you move this incantation into a script e.g. `/usr/local/bin/apt-install-and-clear` or something? and add a tests/lint/ script to verify that "apt-get install" and "apt install" don't appear anywhere inside docker/? ########## docker/install/ubuntu_install_zephyr.sh: ########## @@ -38,10 +39,12 @@ sudo apt-key add kitware-archive-latest.asc echo deb https://apt.kitware.com/ubuntu/ bionic main\ >> /etc/apt/sources.list.d/kitware.list -sudo apt-get update +sudo apt-get update --fix-missing Review Comment: also it'd be great if we could somehow not apt update if no sources.list.d changed. maybe we could make our script run e.g. `find /etc/apt/sources.list.d /etc/apt/sources.list | xargs md5sum | md5sum` and store the output in /var/apt-update-md5 and only rerun when there is a mismatch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
