areusch commented on code in PR #12028:
URL: https://github.com/apache/tvm/pull/12028#discussion_r931630231
##########
tests/python/frontend/caffe2/test_forward.py:
##########
@@ -14,15 +14,22 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=no-else-return
Review Comment:
this one should be disabled globally per #11327 . do you need it here?
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -14,23 +14,35 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=import-self, invalid-name, unused-argument, unused-variable,
missing-function-docstring, redefined-builtin, consider-using-f-string
Review Comment:
possible to not define some of these at file level? otherwise, reminder to
add a comment here.
##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -14,12 +14,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=invalid-name, missing-docstring
Review Comment:
can you just comment why you added these?
##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -113,173 +114,175 @@ def to_channels_last(arr):
tvm.testing.assert_allclose(kout, tout, rtol=1e-5, atol=1e-5)
-def get_mobilenet(keras):
- if hasattr(keras.applications, "MobileNet"):
+def get_mobilenet(keras_):
Review Comment:
since `keras_` isn't a private member, might suggest keras_mod or keras_lib
or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
