masahi commented on PR #11825:
URL: https://github.com/apache/tvm/pull/11825#issuecomment-1217407841

   @chengven027-intellif I've just hit a bug with `SplitInferCorrectLayout`. 
The model I have `split` op which splits along `C` dim in `NCHW` like this:
   
   ```
     %514 = multiply(%512, %513) /* ty=Tensor[(1, 256, 30, 17), float16] */;
     %515 = split(%514, indices_or_sections=[128], axis=-3) /* ty=(Tensor[(1, 
128, 30, 17), float16], Tensor[(1, 128, 30, 17), float16]) */;
   ```
   
   This is going to be a problem for x86 or other backend that uses `NCHWc` 
layout. Since the original splitting axis is blocked along two axes, 
`SplitInferCorrectLayout` needs to change both `indices_or_sections` and `axis` 
parameters. Right now our `split` op supports only integer axis, so this change 
could be difficult.
   
   Unless you have a solution, I think we need to revert this PR. Or specially 
handle `NCHWc` layout by giving up layout fall-through (insert 
`layout_transform`) if the input layout is `NCHWc`.
   
   You can reproduce this error by running 
https://gist.github.com/masahi/dce79525a5d0bd9c8a5d04992c060ab0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to