Lunderberg opened a new pull request, #13081: URL: https://github.com/apache/tvm/pull/13081
Prior to this commit, any use of negative coefficients in `ModularSet` would result in an error. This included cases where a constraint is being entered, such as `floormod(i, -2)==0` appearing as the condition of an if/else block. These negative indices can also arise as intermediate simplification steps produced by `CanonicalSimplifier`, such as `floormod(-i,2)` being canonicalized to `floormod(i,-2)`. This commit adds support for negative coefficients in `ModularSet`, using the same sign convention as is used by `CanonicalSimplifier` for negative denominators, and adds unit tests to verify that sign convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
