[accumulo] branch 2.1 updated: logs info when a tablet consistency check goes from bad to good (#3574)

[kturner]

This is an automated email from the ASF dual-hosted git repository.

kturner pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new 20cecbe8b9 logs info when a tablet consistency check goes from bad to 
good (#3574)
20cecbe8b9 is described below

commit 20cecbe8b9c8b55d17f341dfd64f5b42f7f79705
Author: Keith Turner <ktur...@apache.org>
AuthorDate: Mon Jul 10 11:29:05 2023 -0400

    logs info when a tablet consistency check goes from bad to good (#3574)
    
    When the tablet server does a periodic consistency check on a tablet
    it logs an error when there is a mismatch.  Later if there is no
    longer a mismatch, then this commit changes the code to log an info.
    
    related to #3537 but does not fix that issue
---
 .../java/org/apache/accumulo/tserver/tablet/Tablet.java     | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
index 489dbd0700..1b818d8759 100644
--- 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
+++ 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
@@ -1114,6 +1114,8 @@ public class Tablet extends TabletBase {
     }
   }
 
+  private boolean loggedErrorForTabletComparison = false;
+
   /**
    * Checks that tablet metadata from the metadata table matches what this 
tablet has in memory. The
    * caller of this method must acquire the updateCounter parameter before 
acquiring the
@@ -1162,10 +1164,17 @@ public class Tablet extends TabletBase {
       } else {
         log.error("Data files in {} differ from in-memory data {} {} {} {}", 
extent,
             tabletMetadata.getFilesMap(), dataFileSizes, updateCounter, 
latestCount);
+        loggedErrorForTabletComparison = true;
       }
     } else {
-      log.trace("AMCC Tablet {} files in memory are same as in metadata table 
{}",
-          tabletMetadata.getExtent(), updateCounter);
+      if (loggedErrorForTabletComparison) {
+        log.info("AMCC Tablet {} files in memory are now same as in metadata 
table {}",
+            tabletMetadata.getExtent(), updateCounter);
+        loggedErrorForTabletComparison = false;
+      } else {
+        log.trace("AMCC Tablet {} files in memory are same as in metadata 
table {}",
+            tabletMetadata.getExtent(), updateCounter);
+      }
     }
   }