[accumulo] branch 2.1 updated: change exit error code for ZooPropEditor (#3664)

[ctubbsii]

This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new fdee413764 change exit error code for ZooPropEditor (#3664)
fdee413764 is described below

commit fdee413764ea3bf14936d14613cbe204ac50c396
Author: EdColeman <d...@etcoleman.com>
AuthorDate: Wed Aug 2 08:53:03 2023 +0000

    change exit error code for ZooPropEditor (#3664)
    
    * change exit error code
    
    * address pr comment - removed call to System.exit
    
    ---------
    
    Co-authored-by: Ed Coleman <edcole...@apache.org>
---
 .../java/org/apache/accumulo/server/conf/util/ZooPropEditor.java  | 8 --------
 1 file changed, 8 deletions(-)

diff --git 
a/server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java
 
b/server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java
index 7280f4ef0d..ff277202fa 100644
--- 
a/server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java
+++ 
b/server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java
@@ -57,8 +57,6 @@ import org.slf4j.LoggerFactory;
 import com.beust.jcommander.Parameter;
 import com.google.auto.service.AutoService;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 @AutoService(KeywordExecutable.class)
 public class ZooPropEditor implements KeywordExecutable {
 
@@ -82,8 +80,6 @@ public class ZooPropEditor implements KeywordExecutable {
         + " Prefer using the shell if it is available";
   }
 
-  @SuppressFBWarnings(value = "DM_EXIT",
-      justification = "System.exit() used to set command error status on exit")
   @Override
   public void execute(String[] args) throws Exception {
     ZooPropEditor.Opts opts = new ZooPropEditor.Opts();
@@ -111,10 +107,6 @@ public class ZooPropEditor implements KeywordExecutable {
         default:
           throw new IllegalArgumentException("Invalid operation requested");
       }
-    } catch (Exception ex) {
-      LOG.error("{} command failed", keyword(), ex);
-      // hard fail - set exit status
-      System.exit(-1);
     }
   }