This is an automated email from the ASF dual-hosted git repository.
domgarguilo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/main by this push:
new d91178f44c Replaced System.currentTimeMillis() with System.nanoTime()
in DfsLogger (#4250)
d91178f44c is described below
commit d91178f44cd00cbdc1f305675c9f36a36ab86d96
Author: Arbaaz Khan <[email protected]>
AuthorDate: Mon Feb 12 15:49:44 2024 -0500
Replaced System.currentTimeMillis() with System.nanoTime() in DfsLogger
(#4250)
* Replaced System.currentTimeMillis() with System.nanoTime()
---
.../main/java/org/apache/accumulo/tserver/log/DfsLogger.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
index c0ed0aed39..020144f9d9 100644
---
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
+++
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
@@ -20,6 +20,8 @@ package org.apache.accumulo.tserver.log;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Collections.singletonList;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
import static org.apache.accumulo.tserver.logger.LogEvents.COMPACTION_FINISH;
import static org.apache.accumulo.tserver.logger.LogEvents.COMPACTION_START;
import static org.apache.accumulo.tserver.logger.LogEvents.DEFINE_TABLET;
@@ -172,7 +174,7 @@ public final class DfsLogger implements
Comparable<DfsLogger> {
}
}
- long start = System.currentTimeMillis();
+ long start = System.nanoTime();
try {
if (shouldHSync.isPresent()) {
if (shouldHSync.orElseThrow()) {
@@ -186,9 +188,9 @@ public final class DfsLogger implements
Comparable<DfsLogger> {
} catch (IOException | RuntimeException ex) {
fail(work, ex, "synching");
}
- long duration = System.currentTimeMillis() - start;
- if (duration > slowFlushMillis) {
- log.info("Slow sync cost: {} ms, current pipeline: {}", duration,
+ long duration = System.nanoTime() - start;
+ if (duration > MILLISECONDS.toNanos(slowFlushMillis)) {
+ log.info("Slow sync cost: {} ms, current pipeline: {}",
NANOSECONDS.toMillis(duration),
Arrays.toString(getPipeLine()));
if (expectedReplication > 0) {
int current = expectedReplication;