This is an automated email from the ASF dual-hosted git repository.
ddanielr pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push:
new 8065324d9f Moves log messages from trace to debug (#5649)
8065324d9f is described below
commit 8065324d9f36eccafa99705529c6bc44daaaa173
Author: Daniel Roberts <[email protected]>
AuthorDate: Wed Jun 18 13:14:13 2025 -0400
Moves log messages from trace to debug (#5649)
* Moves log messages from trace to debug
Moves the timing information for assignments and balancing up to a debug
level.
Splits assignment set debug message into two parts.
Summary information is kept at debug level while the full set details
are lowered to trace.
Lowers currently migrating tablets down to trace level.
* Lower spammy message to trace level
* Log balancer class name that generated migrations
---
.../core/spi/balancer/HostRegexTableLoadBalancer.java | 17 ++++++++++-------
.../manager/balancer/BalancerEnvironmentImpl.java | 2 +-
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git
a/core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java
b/core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java
index 05efab3424..4637d8c610 100644
---
a/core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java
+++
b/core/src/main/java/org/apache/accumulo/core/spi/balancer/HostRegexTableLoadBalancer.java
@@ -370,12 +370,13 @@ public class HostRegexTableLoadBalancer extends
TableLoadBalancer {
continue;
}
}
- LOG.debug("Sending {} tablets to balancer for table {} for assignment
within tservers {}",
- e.getValue().size(), tableName, currentView.keySet());
+ LOG.debug("Sending {} tablets to balancer for table {} for assignment
within {} tservers",
+ e.getValue().size(), tableName, currentView.keySet().size());
+ LOG.trace("table {} tserver assignment set {}", tableName,
currentView.keySet());
assignmentTimer.restart();
getBalancerForTable(e.getKey())
.getAssignments(new AssignmentParamsImpl(currentView, e.getValue(),
newAssignments));
- LOG.trace("assignment results table:{} assignments:{} time:{}ms",
tableName,
+ LOG.debug("assignment results table:{} assignments:{} time:{}ms",
tableName,
newAssignments.size(),
assignmentTimer.elapsed(TimeUnit.MILLISECONDS));
newAssignments.forEach(params::addAssignment);
}
@@ -517,9 +518,11 @@ public class HostRegexTableLoadBalancer extends
TableLoadBalancer {
}
ArrayList<TabletMigration> newMigrations = new ArrayList<>();
balanceTimer.restart();
- getBalancerForTable(tableId).balance(new BalanceParamsImpl(currentView,
migrations,
- newMigrations, params.partitionName() + ":" + tableId,
Map.of(tableName, tableId)));
- LOG.trace("balance results tableId:{} migrations:{} time:{}ms", tableId,
newMigrations.size(),
+ TabletBalancer tableBalancer = getBalancerForTable(tableId);
+ tableBalancer.balance(new BalanceParamsImpl(currentView, migrations,
newMigrations,
+ params.partitionName() + ":" + tableId, Map.of(tableName, tableId)));
+ LOG.debug("balance results class:{} tableId:{} migrations:{} time:{}ms",
+ tableBalancer.getClass().getSimpleName(), tableId,
newMigrations.size(),
balanceTimer.elapsed(TimeUnit.MILLISECONDS));
if (newMigrations.isEmpty()) {
@@ -546,7 +549,7 @@ public class HostRegexTableLoadBalancer extends
TableLoadBalancer {
}
LOG.info("Migrating {} tablets for balance.", migrationsOut.size());
- LOG.debug("Tablets currently migrating: {}", migrationsOut);
+ LOG.trace("Tablets currently migrating: {}", migrationsOut);
return minBalanceTime;
}
diff --git
a/server/base/src/main/java/org/apache/accumulo/server/manager/balancer/BalancerEnvironmentImpl.java
b/server/base/src/main/java/org/apache/accumulo/server/manager/balancer/BalancerEnvironmentImpl.java
index f44e290eec..be6a904880 100644
---
a/server/base/src/main/java/org/apache/accumulo/server/manager/balancer/BalancerEnvironmentImpl.java
+++
b/server/base/src/main/java/org/apache/accumulo/server/manager/balancer/BalancerEnvironmentImpl.java
@@ -86,7 +86,7 @@ public class BalancerEnvironmentImpl extends
ServiceEnvironmentImpl implements B
@Override
public List<TabletStatistics> listOnlineTabletsForTable(TabletServerId
tabletServerId,
TableId tableId) throws AccumuloException, AccumuloSecurityException {
- log.debug("Scanning tablet server {} for table {}", tabletServerId,
tableId);
+ log.trace("Scanning tablet server {} for table {}", tabletServerId,
tableId);
try {
TabletClientService.Client client =
ThriftUtil.getClient(ThriftClientTypes.TABLET_SERVER,
HostAndPort.fromParts(tabletServerId.getHost(),
tabletServerId.getPort()), getContext());
