(accumulo) branch main updated: Improve compactor idle checks in two ITs (#6491)

[domgarguilo]

This is an automated email from the ASF dual-hosted git repository.

DomGarguilo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/main by this push:
     new 679cc00b34 Improve compactor idle checks in two ITs (#6491)
679cc00b34 is described below

commit 679cc00b34eb51ec94980fd459ee390f24f63878
Author: Amanda Villarreal <48224036+amem...@users.noreply.github.com>
AuthorDate: Mon Aug 17 11:46:47 2026 -0500

    Improve compactor idle checks in two ITs (#6491)
    
    * Verify compactors are done running jobs and not running compactions for 
user tables to remove 2 TODOS from 2 compaction ITs
---
 .../test/compaction/ExternalCompaction4_IT.java    |  2 +-
 .../compaction/ExternalCompactionMetricsIT.java    | 24 ++++++++++++++--------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git 
a/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction4_IT.java
 
b/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction4_IT.java
index f8fc634ed7..7b9bed4d5f 100644
--- 
a/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction4_IT.java
+++ 
b/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction4_IT.java
@@ -148,7 +148,7 @@ public class ExternalCompaction4_IT extends 
AccumuloClusterHarness {
     try (AccumuloClient client =
         Accumulo.newClient().from(getCluster().getClientProperties()).build()) 
{
 
-      createTable(client, table1, "cs4"); // TODO which service
+      createTable(client, table1, "cs4");
       TableId tid = getCluster().getServerContext().getTableId(table1);
       writeData(client, table1);
 
diff --git 
a/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java
 
b/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java
index f3f74319a7..a23fb89cc7 100644
--- 
a/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java
+++ 
b/test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java
@@ -35,6 +35,7 @@ import static 
org.apache.accumulo.test.compaction.ExternalCompactionTestUtils.cr
 import static 
org.apache.accumulo.test.compaction.ExternalCompactionTestUtils.verify;
 import static 
org.apache.accumulo.test.compaction.ExternalCompactionTestUtils.writeData;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.Collection;
 import java.util.List;
@@ -46,12 +47,14 @@ import java.util.function.DoublePredicate;
 import org.apache.accumulo.core.client.Accumulo;
 import org.apache.accumulo.core.client.AccumuloClient;
 import org.apache.accumulo.core.conf.Property;
+import org.apache.accumulo.core.dataImpl.KeyExtent;
+import org.apache.accumulo.core.metadata.SystemTables;
 import org.apache.accumulo.core.metadata.schema.Ample.DataLevel;
 import org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType;
 import org.apache.accumulo.core.metadata.schema.TabletsMetadata;
 import org.apache.accumulo.core.metrics.MetricsInfo;
 import org.apache.accumulo.core.spi.metrics.LoggingMeterRegistryFactory;
-import org.apache.accumulo.core.util.UtilWaitThread;
+import org.apache.accumulo.core.util.compaction.ExternalCompactionUtil;
 import org.apache.accumulo.core.util.threads.Threads;
 import org.apache.accumulo.minicluster.ServerType;
 import org.apache.accumulo.miniclusterImpl.MiniAccumuloConfigImpl;
@@ -61,6 +64,7 @@ import org.apache.accumulo.test.harness.SharedMiniClusterBase;
 import org.apache.accumulo.test.metrics.TestStatsDRegistryFactory;
 import org.apache.accumulo.test.metrics.TestStatsDSink;
 import org.apache.accumulo.test.metrics.TestStatsDSink.Metric;
+import org.apache.accumulo.test.util.Wait;
 import org.apache.hadoop.conf.Configuration;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
@@ -214,20 +218,22 @@ public class ExternalCompactionMetricsIT extends 
SharedMiniClusterBase {
       thread.join();
 
       // Wait for all external compactions to complete
-      long count;
-      do {
-        // TODO: Change this from waiting to verifying that all compactors are 
done running jobs,
-        // not just check that the jobs have been polled off the queues.
-        UtilWaitThread.sleep(10000);
+      Wait.waitFor(() -> {
         try (TabletsMetadata tm = 
getCluster().getServerContext().getAmple().readTablets()
             .forLevel(DataLevel.USER).fetch(ColumnType.ECOMP).build()) {
-          count = tm.stream().mapToLong(t -> 
t.getExternalCompactions().keySet().size()).sum();
+          return tm.stream().allMatch(t -> 
t.getExternalCompactions().isEmpty());
         }
-      } while (count > 0);
+      });
+
+      // verify any running compactions contains only system tables
+      
ExternalCompactionUtil.getCompactionsRunningOnCompactors(getCluster().getServerContext(),
+          externalCompaction -> {
+            var tableId = 
KeyExtent.fromThrift(externalCompaction.getJob().getExtent()).tableId();
+            assertTrue(SystemTables.tableIds().contains(tableId));
+          });
 
       verify(client, table1, 7);
       verify(client, table2, 13);
-
     }
   }