[ 
https://issues.apache.org/jira/browse/ACE-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649476#comment-15649476
 ] 

Matt Magoffin commented on ACE-600:
-----------------------------------

I dove into the code (my first time) and found a couple of places where a small 
fix allowed working with these artifacts. I pushed up a branch with my changes 
here:

https://github.com/apache/ace/compare/trunk...msqr:ace-600-manifest-not-first 

> Cannot add artifacts if MANIFEST.MF is not at start of JAR
> ----------------------------------------------------------
>
>                 Key: ACE-600
>                 URL: https://issues.apache.org/jira/browse/ACE-600
>             Project: ACE
>          Issue Type: Bug
>            Reporter: Matt Magoffin
>
> I've been attempting to upload some existing OSGi bundle artifacts into ACE 
> (via the web UI) and some JARs are being rejected as "
> Looking into the issue, I found that the JARs are being rejected because when 
> {{org.apache.ace.client.repository.helper.bundle.impl.BundleHelperImpl}} is 
> getting a {{null}} {{Manifest}} object from the {{JarInputStream}} it created 
> from the uploaded artifact:
> {code:java}
> JarInputStream jis = null;
> try {
>       jis = new JarInputStream(artifact.openStream());
>       Manifest manifest = jis.getManifest();
> {code}
>  It turns out {{JarInputStream}} will only return a {{Manifest}} in this way 
> if it is at the start of the JAR file, but these failing artifacts have the 
> {{META-INF/MANIFEST.MF}} entry later on in the archive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to