Repository: activemq Updated Branches: refs/heads/master 91213010b -> 91d277ccb
Make the result value in the listener volatile since it is read from and written to in multiple threads without sync. Project: http://git-wip-us.apache.org/repos/asf/activemq/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/91d277cc Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/91d277cc Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/91d277cc Branch: refs/heads/master Commit: 91d277ccb09f25d10c1f172aa53da12ba362bcd7 Parents: 9121301 Author: Timothy Bish <[email protected]> Authored: Mon May 9 16:10:50 2016 -0400 Committer: Timothy Bish <[email protected]> Committed: Mon May 9 16:11:06 2016 -0400 ---------------------------------------------------------------------- .../activemq/transport/mqtt/PahoMQTTTest.java | 38 +++++++++++--------- 1 file changed, 22 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq/blob/91d277cc/activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/PahoMQTTTest.java ---------------------------------------------------------------------- diff --git a/activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/PahoMQTTTest.java b/activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/PahoMQTTTest.java index 2890831..c105b5f 100644 --- a/activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/PahoMQTTTest.java +++ b/activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/PahoMQTTTest.java @@ -17,27 +17,33 @@ package org.apache.activemq.transport.mqtt; -import org.apache.activemq.ActiveMQConnection; -import org.apache.activemq.broker.region.Destination; -import org.apache.activemq.broker.region.RegionBroker; -import org.apache.activemq.command.ActiveMQQueue; -import org.apache.activemq.util.Wait; -import org.eclipse.paho.client.mqttv3.*; -import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence; -import org.junit.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; -import javax.jms.Message; -import javax.jms.MessageConsumer; -import javax.jms.MessageListener; -import javax.jms.Session; import java.util.concurrent.CountDownLatch; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.atomic.AtomicReference; -import static org.junit.Assert.*; +import javax.jms.Message; +import javax.jms.MessageConsumer; +import javax.jms.MessageListener; +import javax.jms.Session; + +import org.apache.activemq.ActiveMQConnection; +import org.apache.activemq.util.Wait; +import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken; +import org.eclipse.paho.client.mqttv3.MqttCallback; +import org.eclipse.paho.client.mqttv3.MqttClient; +import org.eclipse.paho.client.mqttv3.MqttConnectOptions; +import org.eclipse.paho.client.mqttv3.MqttMessage; +import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class PahoMQTTTest extends MQTTTestSupport { @@ -454,7 +460,7 @@ public class PahoMQTTTest extends MQTTTestSupport { static class DefaultListener implements MqttCallback { int received = 0; - String result; + volatile String result; @Override public void connectionLost(Throwable cause) {
