ARTEMIS-1308 Removing start/endcall around commit this issue many warning around the testsuite around MessageListeners it's valid to call the commit from a different thread on this case.
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/7b5d9f12 Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/7b5d9f12 Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/7b5d9f12 Branch: refs/heads/master Commit: 7b5d9f120ca74f3c22ec837dfb17ef662887721c Parents: 5909a24 Author: Clebert Suconic <[email protected]> Authored: Tue Aug 8 20:30:39 2017 -0400 Committer: Clebert Suconic <[email protected]> Committed: Wed Aug 9 15:18:54 2017 -0400 ---------------------------------------------------------------------- .../activemq/artemis/core/client/impl/ClientSessionImpl.java | 3 --- 1 file changed, 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7b5d9f12/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java ---------------------------------------------------------------------- diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java index ef4e87c..41330a6 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java @@ -787,7 +787,6 @@ public final class ClientSessionImpl implements ClientSessionInternal, FailureLi if (rollbackOnly) { rollbackOnFailover(true); } - startCall(); try { sessionContext.simpleCommit(block); } catch (ActiveMQException e) { @@ -800,8 +799,6 @@ public final class ClientSessionImpl implements ClientSessionInternal, FailureLi } else { throw e; } - } finally { - endCall(); } //oops, we have failed over during the commit and don't know what happened
