ARTEMIS-1741 - log warning if a node isnt configured for quorum voting https://issues.apache.org/jira/browse/ARTEMIS-1741
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/3c6876ec Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/3c6876ec Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/3c6876ec Branch: refs/heads/master Commit: 3c6876ece61880dbe1a5ea0f50f43e13b803dded Parents: 2cc163d Author: andytaylor <andy.tayl...@gmail.com> Authored: Fri Mar 9 10:19:34 2018 +0000 Committer: Justin Bertram <jbert...@apache.org> Committed: Fri Mar 9 09:10:55 2018 -0600 ---------------------------------------------------------------------- .../activemq/artemis/core/server/ActiveMQServerLogger.java | 5 +++++ .../activemq/artemis/core/server/cluster/ClusterController.java | 4 ++++ 2 files changed, 9 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3c6876ec/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java ---------------------------------------------------------------------- diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java index ce04f14..4d25c58 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java @@ -1918,4 +1918,9 @@ public interface ActiveMQServerLogger extends BasicLogger { @LogMessage(level = Logger.Level.WARN) @Message(id = 224089, value = "Failed to calculate persistent size", format = Message.Format.MESSAGE_FORMAT) void errorCalculatePersistentSize(@Cause Throwable e); + + @LogMessage(level = Logger.Level.WARN) + @Message(id = 224090, value = "This node is not configured for Quorum Voting, all nodes must be configured for HA", format = Message.Format.MESSAGE_FORMAT) + void noVoteHandlerConfigured(); + } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3c6876ec/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java ---------------------------------------------------------------------- diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java index 464e945..c77b297 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java @@ -378,6 +378,10 @@ public class ClusterController implements ActiveMQComponent { } else if (packet.getType() == PacketImpl.QUORUM_VOTE) { QuorumVoteMessage quorumVoteMessage = (QuorumVoteMessage) packet; QuorumVoteHandler voteHandler = quorumManager.getVoteHandler(quorumVoteMessage.getHandler()); + if (voteHandler == null) { + ActiveMQServerLogger.LOGGER.noVoteHandlerConfigured(); + return; + } quorumVoteMessage.decode(voteHandler); ActiveMQServerLogger.LOGGER.receivedQuorumVoteRequest(quorumVoteMessage.getVote().toString()); Vote vote = quorumManager.vote(quorumVoteMessage.getHandler(), quorumVoteMessage.getVote());
