Repository: activemq-artemis
Updated Branches:
  refs/heads/master 6ec375bdb -> 2feacd5d5


NO-JIRA Providing information about failure on test

Travis CI has been reporting test failures.
Looking on logs I could see a critical failure happening but not much 
information on why.
This will help identify further issues.


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/65db3171
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/65db3171
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/65db3171

Branch: refs/heads/master
Commit: 65db3171764c65923acb7738ef07d7f51079f046
Parents: 6ec375b
Author: Clebert Suconic <clebertsuco...@apache.org>
Authored: Wed Apr 4 13:46:40 2018 -0400
Committer: Clebert Suconic <clebertsuco...@apache.org>
Committed: Wed Apr 4 16:05:48 2018 -0400

----------------------------------------------------------------------
 .../activemq/artemis/core/io/AbstractSequentialFileFactory.java    | 2 +-
 .../activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java      | 1 +
 .../tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java   | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/65db3171/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
----------------------------------------------------------------------
diff --git 
a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
 
b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
index 1d7a017..5f191cf 100644
--- 
a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
+++ 
b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
@@ -187,7 +187,7 @@ public abstract class AbstractSequentialFileFactory 
implements SequentialFileFac
       if (critialErrorListener != null) {
          critialErrorListener.onIOException(exception, message, file);
       } else {
-         logger.warn("Critical IO Error Called.  No Critical IO Error Handler 
Registered");
+         logger.warn("Critical IO Error Called.  No Critical IO Error Handler 
Registered::" + message + " at file " + file, exception);
       }
    }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/65db3171/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java
----------------------------------------------------------------------
diff --git 
a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java
 
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java
index d5a7f5a..25eccbc 100644
--- 
a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java
+++ 
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/AIOTestBase.java
@@ -114,6 +114,7 @@ public abstract class AIOTestBase extends ActiveMQTestBase {
 
       @Override
       public void onError(final int errorCode, final String errorMessage) {
+         new Exception("Error called:: " + errorCode + " message::" + 
errorMessage).printStackTrace();
          errorCalled++;
          if (outputList != null) {
             outputList.add(order);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/65db3171/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
----------------------------------------------------------------------
diff --git 
a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
 
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
index 526663f..e9f51f9 100644
--- 
a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
+++ 
b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
@@ -210,8 +210,8 @@ public class MultiThreadAsynchronousFileTest extends 
AIOTestBase {
                addData(libaio, buffer, callback);
                if (sync) {
                   waitForLatch(latchFinishThread);
+                  assertEquals(0, callback.errorCalled);
                   assertTrue(callback.doneCalled);
-                  assertFalse(callback.errorCalled != 0);
                }
             }
             if (!sync) {

Reply via email to