Repository: activemq-artemis Updated Branches: refs/heads/master fe8a4b78c -> 71390fea4
NO-JIRA - Update SimpleString to give a more useful error message Currently we get. java.lang.IndexOutOfBoundsException: null at org.apache.activemq.artemis.api.core.SimpleString.readSimpleString(SimpleString.java:183) at org.apache.activemq.artemis.api.core.SimpleString$ByteBufSimpleStringPool.create(SimpleString.java:584) .... Should be java.lang.IndexOutOfBoundsException: Error reading in simpleString, length=YYY is greater than readableBytes=XXX at org.apache.activemq.artemis.api.core.SimpleString.readSimpleString(SimpleString.java:183) at org.apache.activemq.artemis.api.core.SimpleString$ByteBufSimpleStringPool.create(SimpleString.java:584) ... Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/153e0a02 Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/153e0a02 Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/153e0a02 Branch: refs/heads/master Commit: 153e0a0260c9b143a2ed21b80b4fc07af5f18428 Parents: fe8a4b7 Author: henock <[email protected]> Authored: Tue Sep 11 14:48:17 2018 +0100 Committer: GitHub <[email protected]> Committed: Tue Sep 11 14:48:17 2018 +0100 ---------------------------------------------------------------------- .../java/org/apache/activemq/artemis/api/core/SimpleString.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/153e0a02/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java ---------------------------------------------------------------------- diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java index 96e48b8..aabffa1 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java @@ -180,7 +180,7 @@ public final class SimpleString implements CharSequence, Serializable, Comparabl public static SimpleString readSimpleString(final ByteBuf buffer, final int length) { if (length > buffer.readableBytes()) { - throw new IndexOutOfBoundsException(); + throw new IndexOutOfBoundsException("Error reading in simpleString, length=" + length + " is greater than readableBytes=" + buffer.readableBytes()); } byte[] data = new byte[length]; buffer.readBytes(data);
