NO-JIRA Fix errorprone error (duplicated expression in condition)
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/94c158eb Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/94c158eb Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/94c158eb Branch: refs/heads/master Commit: 94c158ebee4d35dc0fef3c9ac36b68a623ae5eb5 Parents: 4231d66 Author: Jiri Danek <jda...@redhat.com> Authored: Thu Nov 22 22:52:45 2018 +0100 Committer: Justin Bertram <jbert...@apache.org> Committed: Thu Dec 13 10:53:34 2018 -0600 ---------------------------------------------------------------------- .../artemis/protocol/amqp/broker/AMQPMessageTest.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/94c158eb/artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java ---------------------------------------------------------------------- diff --git a/artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java b/artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java index 953dd0b..12b91ea 100644 --- a/artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java +++ b/artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java @@ -17,6 +17,7 @@ package org.apache.activemq.artemis.protocol.amqp.broker; +import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotEquals; @@ -1465,7 +1466,7 @@ public class AMQPMessageTest { AMQPMessage readMessage = (AMQPMessage)decoded.getPersister().decode(buffer, null); Assert.assertEquals(33, readMessage.getMessageID()); Assert.assertEquals("someAddress", readMessage.getAddress()); - Assert.assertArrayEquals(original, readMessage.getExtraBytesProperty(name)); + assertArrayEquals(original, readMessage.getExtraBytesProperty(name)); } finally { buffer.release(); } @@ -1475,7 +1476,7 @@ public class AMQPMessageTest { AMQPMessage readMessage = (AMQPMessage) EmbedMessageUtil.extractEmbedded(embeddedMessage); Assert.assertEquals(33, readMessage.getMessageID()); Assert.assertEquals("someAddress", readMessage.getAddress()); - Assert.assertArrayEquals(original, readMessage.getExtraBytesProperty(name)); + assertArrayEquals(original, readMessage.getExtraBytesProperty(name)); } } @@ -2231,14 +2232,14 @@ public class AMQPMessageTest { byte[] leftArray = leftValue.getValue().getArray(); byte[] rightArray = rightValue.getValue().getArray(); - if (leftArray == null && leftArray == null) { + if (leftArray == null && rightArray == null) { return true; } if (!isNullnessEquals(leftArray, rightArray)) { return false; } - assertTrue(Arrays.equals(leftArray, rightArray)); + assertArrayEquals(leftArray, rightArray); } else { return false; }
