This is an automated email from the ASF dual-hosted git repository.
jbertram pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/master by this push:
new 6d379d1 NO-JIRA visually separate the controls in groups
new 0cb7650 This closes #3496
6d379d1 is described below
commit 6d379d1aa73e1ad2e203385b1af91969e5b63729
Author: Erwin Dondorp <[email protected]>
AuthorDate: Fri Mar 12 12:00:20 2021 +0100
NO-JIRA visually separate the controls in groups
The "filter" toolbar above many pages has all controls without spacing.
This PR inserts a little bit of spacing to make the groups of controls
more obvious.
Spacing is applied 3 times:
- at the start of the row to separate it from the left margin
- at "sort order" to separate the "filter" group from the "ordering"
group
- at "columns" to separate it from "reset"
Since the "looking glass" being an icon, no extra spacing was needed
there.
Note: I tried to use "1em" as spacing, but that did not work, so this PR
uses "10px".
---
.../artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
b/artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
index 7c165c9..7329fc9 100644
---
a/artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
+++
b/artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
@@ -25,7 +25,7 @@ var Artemis;
<form class="toolbar-pf-actions">
<div class="form-group toolbar-pf-filter">
<div class="input-group">
- <div class="input-group-btn">
+ <div class="input-group-btn"
style="padding-left: 10px">
<button id="filter.values.field"
type="button" class="btn btn-default dropdown-toggle" id="filter"
data-toggle="dropdown" aria-haspopup="true"
aria-expanded="false">{{$ctrl.filter.text.fieldText}} <span
class="caret"></span></button>
<ul class="dropdown-menu">
<li ng-repeat="option in
$ctrl.filter.fieldOptions"
@@ -40,7 +40,7 @@ var Artemis;
</ul>
</div>
<input type="text" class="form-control"
ng-model="$ctrl.filter.values.value" placeholder="Value" autocomplete="off"
id="filterInput">
- <div class="input-group-btn">
+ <div class="input-group-btn"
style="padding-left: 10px">
<button type="button" class="btn
btn-default dropdown-toggle" id="filter" data-toggle="dropdown"
aria-haspopup="true"
aria-expanded="false">{{$ctrl.filter.text.sortOrderText}}<span
class="caret"></span></button>
<ul class="dropdown-menu">
<li ng-repeat="option in
$ctrl.filter.sortOptions"
@@ -66,7 +66,7 @@ var Artemis;
ng-click="$ctrl.reset()">Reset
</button>
</div>
- <div class="input-group-btn">
+ <div class="input-group-btn"
style="padding-left: 10px">
<button class="btn btn-default
primary-action ng-binding ng-scope"
type="button"
title=""
