This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit f14ba5f7420c445cda412f4dd7246fde301a6489
Author: clebert <[email protected]>
AuthorDate: Wed May 25 11:32:14 2022 -0400

    NO-JIRA removing useless assertionRemainingMessages
    
    JMSTestCase is deprecated anyway.
    in its older form many many years ago a server would be reused over
    between tests.
    
    what forced us to make such verification to avoid messages from one test
    leaking into the next.
    
    This was because a server startup was expensive many years ago (less
    efficient code and the hardware available 10 years ago)
    
    with the current state of things this is not needed as the server will
    be started from scratch on every test
---
 .../test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java  | 4 ----
 1 file changed, 4 deletions(-)

diff --git 
a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java
 
b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java
index 45f5a4923e..508e9c2cd0 100644
--- 
a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java
+++ 
b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java
@@ -69,8 +69,6 @@ public class JMSTestCase extends ActiveMQServerTestCase {
       cf = new 
ActiveMQJMSConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
       queueCf = new 
ActiveMQQueueConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
       topicCf = new 
ActiveMQTopicConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
-
-      assertRemainingMessages(0);
    }
 
    protected final JMSContext createContext() {
@@ -115,8 +113,6 @@ public class JMSTestCase extends ActiveMQServerTestCase {
       }
 
       cf = null;
-
-      assertRemainingMessages(0);
    }
 
    protected Connection createConnection(ConnectionFactory cf1) throws 
JMSException {

Reply via email to