This is an automated email from the ASF dual-hosted git repository. robbie pushed a commit to branch new-logging in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
commit be2846755acfede50223fba73ba0569f1cff8974 Author: Robbie Gemmell <[email protected]> AuthorDate: Fri Aug 26 13:33:50 2022 +0100 some notes around reload --- TODO-new-logging.txt | 1 + .../org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/TODO-new-logging.txt b/TODO-new-logging.txt index d0549178aa..ee6588dbb0 100644 --- a/TODO-new-logging.txt +++ b/TODO-new-logging.txt @@ -8,3 +8,4 @@ TODOs not explicitly noted in the code itself already: - Restore the Travis config file - Delete the old DELETE-ME-logging.properties and DELETE-ME-tests-logging.properties files once all needed comparisons during old test etc config replacements are done. - Update references to JBL and logging.properties in the documentation +- Decide what if anything should be done around the removed logging config reload bits (Log4J2 enables reload itself, via its own config...or updates via management) diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java index 2edfb66ed9..f0267e0bed 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java @@ -1142,9 +1142,11 @@ public interface ActiveMQServerLogger { @LogMessage(id = 222275, value = "Failed to deploy queue {}: {}", level = LogMessage.Level.WARN) void problemDeployingQueue(String queueName, String message); + //TODO: deprecate or remove? This is part of the logging config itself now @LogMessage(id = 222276, value = "Failed to process changes to the logging configuration file: {}", level = LogMessage.Level.WARN) void loggingReloadFailed(String configFile, Exception e); + //TODO: deprecate or remove? This is part of the logging config itself now @LogMessage(id = 222277, value = "Problem initializing automatic logging configuration reload for {}", level = LogMessage.Level.WARN) void problemAddingConfigReloadCallback(String propertyName, Exception e);
