This is an automated email from the ASF dual-hosted git repository.
robbie pushed a change to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
discard ae15dfb251 NO-JIRA some real debug I made with the new logging - just
squash with everything else
discard e9419e6696 fixup after rebase against main at
a254e50aae5487148e3a1a3f7dfe54ff5139f88b
discard 24efa3ba64 update notes, remove old comparison files
discard 08e8fa052c remove arg that isnt being used anymore
discard c0d6f17128 add notes
discard 4fda6a945c try out simplifying to use auto-detected log4j2.properties
config file
discard 40ebf979a6 repeat removal to undo compensating commits
discard c5687cd082 suppress unnecessary log4j2.properties file from console
war overlay files
discard 757f498191 update documentation around logging
discard d85b23120c replace jbl reference with slf4j
discard 951f15b9e5 add outline of details for versions.md to cover
discard 563563cb21 remove some remaining logging.properties files
discard 69d8966600 remove comparison logging-CI.properties file as the CI
specific config has gone away entirely
discard 65d1197609 update notes
discard f18add8d52 remove examples config files that seem not to be referenced
anywhere, and reference things that dont seem to exist
discard a6c6d0b3a5 restore comment
discard d089813e7c adjusting defaults
discard 377e7392f0 add note from some looking at the handling
discard 4c82cf35ce some consolidation and simplification of the processor to
make following easier and verification more consistent
discard 99e6f4ce82 Replacing JBL by slf4j on rest
discard c604b19a39 Fix stacktraces of generated exceptions to not include the
generated logmessage method
discard 58dd83cac9 WIP: fixups after rebase onto main at
11eab605842716487b0ca2cd5b019ba71bcc313d
discard 7bd6ddd61f add note
discard 1d4b555d6d action some TODOs, add some others
discard 0a674716e1 some notes around reload
discard 01408184a9 remove a couple TODOs not needed
discard f6433b9deb fixups after rebase to main at
a0f39a4b28545f4010e07d950c34fe9f1f228b68
discard 7f34661a4b fixup header comments
discard a8cfdc2f67 fix some file references and update notes
discard eb206e4b6b convert some more test loggers
discard dc52eb0ef3 remove slf4j->jbl bridge from example
discard bbc729032b replace a couple of examples logging.properties that enable
audit logger output
discard 9b20447b6b add a note
discard 2c84b3b85d remove exclusion that is no longer needed
discard eae13d302a switch another logger missed previously
discard 8d0193477e fixups after rebase to main at
0ca44c0e6972991cf80e5feda34f6d02cf94dea0
discard de2ae1d161 remove uses of JBL from compatibility tests, add
artemis-unit-test-support to snapshots CP to ensure test appender class is
found and avoids stacktracing
discard b6a413a67a add another TODO note
discard 3c26ec9a74 move another old log config file out to root, for any later
comparisons needed
discard 3a2397a928 replace logging.properties files for e2e-tests server
configs
discard a961cbc66c remove commons-logging slf4j bridge now the karaf bits dont
cause beanutils log spam
discard eae9ea329b move karaf server feature test to its own module, its
logging deps mess with the commons-config handling
discard ea0131c718 delete old Log4J 1.x log4j.properties files that shouldnt
be doing anything, build isnt using log4j 1.x / reload4j anymore
discard 36cfb10480 update deps to match actual SLF4J base usage and simplify
discard 98d8ff5574 use latest log4j version
discard 14ea328e07 remove now-unused import
discard 2202a5c04b update notes
discard 88915879e0 remove rather than reinstate a couple of unnecesarry level
manipulations
discard dbcce8940c ensure method or class based cleanups for
AssertionLoggerHandler exist or will be effective, where startCapture() has
been called previously
discard 958724845a reinstate another test manipulating levels
discard 0a7697eb46 restore one of the remaining tests using JBL, manipulating
levels
discard df8903fd98 Revert "add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc"
discard 984432449d Revert "Moving dependencies as test"
discard 6856c44a76 Revert "Remove slf4j bridge depedencies from libs", towards
getting build back to consistent deps state and to more easily revert original
addition leading to issue.
discard a6b1d4d86b fixing build after rebase
discard 30926ccdff Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
discard dcc76707d1 fixing test
discard 181430bdef Moving dependencies as test
discard 1be4d02c31 Remove slf4j bridge depedencies from libs
discard 1e506308a3 Removing log facade package
discard 84238d81f0 make start on updating remaining integration tests,
manipulating levels etc
discard 5877bfd3c2 remove various mentions of jblm and wildfly-common from
scripts etc, update service config logging details..now to see what it breaks
discard 265186257b also move the old main tests logging.config file
discard 33c1b17553 move old base logging.properties out of artemis-cli, but
leave it in root for comparison to see needed config updates as others replaced
discard bca5e124a5 add some TODOs for area cleanup still needed
discard 786eb71669 change remaining integration tests except those with TODOs
discard 03f4bf5b06 Adding safeguard against {?} on LogProcessor
discard a33b0178d9 fix compile issues IDE somehow decided not to show
discard 91bb46e15d more test changes
discard 13868c3628 more test updates
discard 02c12cab0a some more integration test updates
discard 59af9fdb92 make start on updating integration tests
discard 30e37a82f4 add note about e2e-test fixups needed
discard d9e6b4cd8e add artemis-unit-test-support dep to various modules that
have tests, avoid stacktrace on not finding appender from shared logging config
discard 891b4c5d58 Verifying JMX Security and setting up
javax.management.builder.initial before Log4J starts its own JMX
discard bdb0e8c215 add artemis-unit-test-support dep to various modules that
have tests, and will stacktrace if the appender isnt found which is referenced
in their shared logging test config
discard 9ee348a103 fix dep scope
discard 09bba8e56a add note about many integration-tests etc still using JBL
discard abf1f030d0 fix other files similar to commit titled 'Fixing duplicate
properties'
discard 51f3734a90 Fixing duplicate properties
discard 9f9f30319a Setting version as 3.0.0
discard dfb422d9bd updating version after rebasing
discard 36835cf61c add log config to get NettyNativeTest working
discard a53406cc00 simplify test logging config again, adjust assertion to be
more specific and take into account change in output from
07329118c10d14bce018a580b0dadbcf081233a8
discard 22b49e18c6 add log config for AuditLoggerAMQPMutualSSLTest
discard 2c986f37ee ARTEMIS-3902 Adding Reason to Security Exception
discard 78696700a2 add some TODO notes from memory
discard 3aa1a055b1 add some [in-flux] config to get more failing audit log
smoke tests passing
discard 90ce503626 apply needed change only, and remove old unused
logging.properties file
discard 7adbb05c1f reset smoke test config to current base assembly config
discard d3a71a700c some more helper additions to bring default assembly
logging config into line with prior config
discard 227ae38b7e Adding a test with no argument on exception (just to be
sure)
discard 510ed53d83 Removing @Cause annotation
discard 3da48eede4 fix up errorprone error and an IDE warning
discard 5077cf5fea ensure exceptions/causes are the last arg passed, as the
logging framework expects, and processor now enforces
discard a63b29fe1b fix checkstyle on processor
discard f399260bfd small tweak on test
discard 088d30a186 Enforcing exception as the last argument
discard cba4bb53f3 log processing improvement with exceptions
discard af5c707f87 flesh out assembly default logging config, give output like
previous behaviour
discard 1b1ca140fb Removing Reload4J
discard 8b82e2abf2 fix some more placeholders missed previously
discard 35144f45eb make basic start on audit log file config, add [unfinished]
config changes to get AuditLoggerResourceTest smoke test passing
discard 341fb511b4 reorder args to match previously out-of-order placeholders,
ensure new output matches previous
discard f691ee5bf0 remove now-unnecessary quote escaping from log/message
bundle format strings, giving same output as before switch to slf4j formatter
discard 31c1a35e65 switch to released 2.0.0 artemis-native dep
discard 49a312b5f5 Fixing up some {0} versus {}
discard a3a90076db re-enable GHA CI runs in the main repo, build now in state
it can pass the PR test subset (except for
d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it
fail)
discard 37ef22b8f1 add TODO for another fun task
discard 42711d193e fix various test failures due to unexpected message string;
also make some tests indicate why they failed
discard 6892144f12 temporarily remove test to allow concentrating on other
issues
discard f8c0f26661 fix test missed in prior change
discard fbf43568f5 fix format of code prefix in messages, pointed out by
failing test
discard c07b711a09 make a start on a basic loging config for distribution
discard 513c692381 add some more needed deps; essentially every module with
tests (or without specific log test config) will need this to avoid a
stacktrace from logging setup issues
discard 811e2f5f87 avoid NPE in a unit test due to audit loggers still being
enabled, unlike prior test logging config
discard 59294fa705 Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
discard b76066c25d add some deps needed/used already, look into test failure
discard c25cb18500 fixup for release profile following prior rebases+squashes
discard ef6348a420 add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc
discard a606a41c53 basic logging config and some more on
AssertionLoggerHandler to get some tests using it working
discard 101226f874 make a start on restoring AssertionLoggerHandler to get
tests going
discard bc4576161b Artemis native at 2.0 snapshot
discard 617876ec48 squashed logging changes from Clebert + me, rebased onto
main at 065bfe14f532858f2c2a20b0afb1a226b08ce013
discard 14ac30198a compensating commit, Revert "Bumping artemis as 3.0"
discard 61ff08e975 comensating commit, Revert "ARTEMIS-3987 Removing ActiveMQ
Artemis Rest from the codebase."
add 51ccc7d6c2 ARTEMIS-3989 ActiveMQServerControl.getRoles doesn't return
all roles
add d127866dfd This closes #4213
add 902c0cb62b NO-JIRA Removing dead code - AmqpReadableBuffer
add 289587f004 ARTEMIS-3990 Ensure that readable buffer string read
consumes the bytes
add a9a85f98db ARTEMIS-3984 LegacyLDAPSecuritySettingPlugin shouldn't
modify existing matches
add 59585ffc94 NO-JIRA Trying to fix StompV11Test intermittent failure
add f47d592079 ARTEMIS-3988 Moving MMSFactoryTest under soak-tests
add 02d1512be7 ARTEMIS-3967 fix Camel WAR example pom.xml file
add c4fded664b This closes #4202
add 6b5a73db8a ARTEMIS-3913 custom MQTT client ID rejection
add 4b791b502d This closes #4197
add 98d176ae83 ARTEMIS-3748 support older versions in prepare-docker.sh
add abeed34449 This closes #4215
add 015acab8db ARTEMIS-3981 bad docker image if release pull is 404
add 9b535c622a This closes #4216
add 164ae04218 AARTEMIS-3996: update to proton-j 0.34.0
add 3aeb24ae01 ARTEMIS-3997: update vertx-proton test dep to 4.3.3
new 384a77dae1 comensating commit, Revert "ARTEMIS-3987 Removing ActiveMQ
Artemis Rest from the codebase."
new c655dbc34f compensating commit, Revert "Bumping artemis as 3.0"
new 2efc3c1d35 squashed logging changes from Clebert + me, rebased onto
main at 3aeb24ae01f19a37d9378820a40d36624c28288b
new b6f1522c0b Artemis native at 2.0 snapshot
new 7420b40699 make a start on restoring AssertionLoggerHandler to get
tests going
new 2225cddf1e basic logging config and some more on
AssertionLoggerHandler to get some tests using it working
new 0ea7859da2 add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc
new 2641d5a1ae fixup for release profile following prior rebases+squashes
new d57eca646a add some deps needed/used already, look into test failure
new 84b939e4b9 Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
new 89a93db216 avoid NPE in a unit test due to audit loggers still being
enabled, unlike prior test logging config
new 6bb3e4b5a4 add some more needed deps; essentially every module with
tests (or without specific log test config) will need this to avoid a
stacktrace from logging setup issues
new f2e817229a make a start on a basic loging config for distribution
new e1a1be07c6 fix format of code prefix in messages, pointed out by
failing test
new 90aa690fcb fix test missed in prior change
new 9a962ce6d8 temporarily remove test to allow concentrating on other
issues
new fc6f09714d fix various test failures due to unexpected message string;
also make some tests indicate why they failed
new 30b96906d1 add TODO for another fun task
new f6af572586 re-enable GHA CI runs in the main repo, build now in state
it can pass the PR test subset (except for
d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it
fail)
new 0fdd1f46e0 Fixing up some {0} versus {}
new b15cae473c switch to released 2.0.0 artemis-native dep
new 31f92684c4 remove now-unnecessary quote escaping from log/message
bundle format strings, giving same output as before switch to slf4j formatter
new 938fb19a65 reorder args to match previously out-of-order placeholders,
ensure new output matches previous
new a6b56be002 make basic start on audit log file config, add [unfinished]
config changes to get AuditLoggerResourceTest smoke test passing
new 8eeb50dea4 fix some more placeholders missed previously
new df06be39df Removing Reload4J
new 2c98332c0f flesh out assembly default logging config, give output like
previous behaviour
new 35ee35cd6d log processing improvement with exceptions
new 0c99bfb510 Enforcing exception as the last argument
new 43768ea065 small tweak on test
new e14309e098 fix checkstyle on processor
new 49e8809fd4 ensure exceptions/causes are the last arg passed, as the
logging framework expects, and processor now enforces
new d027551c56 fix up errorprone error and an IDE warning
new c94d58c3fb Removing @Cause annotation
new 4271ec457a Adding a test with no argument on exception (just to be
sure)
new c9db9e7c83 some more helper additions to bring default assembly
logging config into line with prior config
new e6ad7b806d reset smoke test config to current base assembly config
new 1d28d04885 apply needed change only, and remove old unused
logging.properties file
new 2ecc48fd70 add some [in-flux] config to get more failing audit log
smoke tests passing
new 96d61cd264 add some TODO notes from memory
new 71eca04b08 ARTEMIS-3902 Adding Reason to Security Exception
new 9671532eec add log config for AuditLoggerAMQPMutualSSLTest
new 08512af35b simplify test logging config again, adjust assertion to be
more specific and take into account change in output from
07329118c10d14bce018a580b0dadbcf081233a8
new 0917c0b22d add log config to get NettyNativeTest working
new 394745d27c updating version after rebasing
new c70ea1500b Setting version as 3.0.0
new 165803f191 Fixing duplicate properties
new 8ae2d4cbb3 fix other files similar to commit titled 'Fixing duplicate
properties'
new edee24642c add note about many integration-tests etc still using JBL
new 2fbe2b896f fix dep scope
new 536170dae3 add artemis-unit-test-support dep to various modules that
have tests, and will stacktrace if the appender isnt found which is referenced
in their shared logging test config
new eb7c8156f3 Verifying JMX Security and setting up
javax.management.builder.initial before Log4J starts its own JMX
new 49d8a24bdf add artemis-unit-test-support dep to various modules that
have tests, avoid stacktrace on not finding appender from shared logging config
new f86378263d add note about e2e-test fixups needed
new e64e452606 make start on updating integration tests
new 9981bfff38 some more integration test updates
new 029e65917d more test updates
new 4e94291980 more test changes
new 8e05c6d625 fix compile issues IDE somehow decided not to show
new 8574230059 Adding safeguard against {?} on LogProcessor
new 4dd01fa8ac change remaining integration tests except those with TODOs
new ecd66b4e0a add some TODOs for area cleanup still needed
new 0a7bbdcad5 move old base logging.properties out of artemis-cli, but
leave it in root for comparison to see needed config updates as others replaced
new c0e5798896 also move the old main tests logging.config file
new 3b0986ae73 remove various mentions of jblm and wildfly-common from
scripts etc, update service config logging details..now to see what it breaks
new 9752f0a950 make start on updating remaining integration tests,
manipulating levels etc
new 9cf37f2bcf Removing log facade package
new 5159ed4667 Remove slf4j bridge depedencies from libs
new f4dbd839ec Moving dependencies as test
new 26942e5d47 fixing test
new 92bdba8aa5 Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
new e111a0b161 fixing build after rebase
new 984ba3647e Revert "Remove slf4j bridge depedencies from libs", towards
getting build back to consistent deps state and to more easily revert original
addition leading to issue.
new 506b23ce8f Revert "Moving dependencies as test"
new 9bc40a383a Revert "add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc"
new 637e082753 restore one of the remaining tests using JBL, manipulating
levels
new fec486d6e7 reinstate another test manipulating levels
new 15bb34aca8 ensure method or class based cleanups for
AssertionLoggerHandler exist or will be effective, where startCapture() has
been called previously
new f4c1a88764 remove rather than reinstate a couple of unnecesarry level
manipulations
new 228f416dd3 update notes
new 1098de12c6 remove now-unused import
new 3602f44a64 use latest log4j version
new fa84b245ef update deps to match actual SLF4J base usage and simplify
new 69ad69ef57 delete old Log4J 1.x log4j.properties files that shouldnt
be doing anything, build isnt using log4j 1.x / reload4j anymore
new 789c78a7e6 move karaf server feature test to its own module, its
logging deps mess with the commons-config handling
new 924e607656 remove commons-logging slf4j bridge now the karaf bits dont
cause beanutils log spam
new 55c0fa9de0 replace logging.properties files for e2e-tests server
configs
new 27dae46958 move another old log config file out to root, for any later
comparisons needed
new d8306534aa add another TODO note
new 1d2544d8e8 remove uses of JBL from compatibility tests, add
artemis-unit-test-support to snapshots CP to ensure test appender class is
found and avoids stacktracing
new 98daddfe19 fixups after rebase to main at
0ca44c0e6972991cf80e5feda34f6d02cf94dea0
new 347c12ad1a switch another logger missed previously
new f17521c967 remove exclusion that is no longer needed
new 36a1fe099c add a note
new 4cd67761e8 replace a couple of examples logging.properties that enable
audit logger output
new c93fb3e110 remove slf4j->jbl bridge from example
new 1f15f61fc5 convert some more test loggers
new f0d0078823 fix some file references and update notes
new 1840c1dc1e fixup header comments
new f63378613b fixups after rebase to main at
a0f39a4b28545f4010e07d950c34fe9f1f228b68
new bb02cc2bee remove a couple TODOs not needed
new cfe82b9e20 some notes around reload
new 48af883d2b action some TODOs, add some others
new e103b894a9 add note
new 91b22f1d7f WIP: fixups after rebase onto main at
11eab605842716487b0ca2cd5b019ba71bcc313d
new 930c64641a Fix stacktraces of generated exceptions to not include the
generated logmessage method
new d9be0856e9 Replacing JBL by slf4j on rest
new a024f47476 some consolidation and simplification of the processor to
make following easier and verification more consistent
new 0bce33e42f add note from some looking at the handling
new 8b1ad43d73 adjusting defaults
new f6fdb2a660 restore comment
new a2089b5d22 remove examples config files that seem not to be referenced
anywhere, and reference things that dont seem to exist
new 0dff739aaa update notes
new 4a9cba957f remove comparison logging-CI.properties file as the CI
specific config has gone away entirely
new b9bb445041 remove some remaining logging.properties files
new 78dc117607 add outline of details for versions.md to cover
new bf52cb2cc5 replace jbl reference with slf4j
new 164ae72896 update documentation around logging
new 3d8e29d3ad suppress unnecessary log4j2.properties file from console
war overlay files
new 78031b9e4b repeat removal to undo compensating commits
new 9fd86f1230 try out simplifying to use auto-detected log4j2.properties
config file
new cb63473140 add notes
new edaec85a05 remove arg that isnt being used anymore
new d1602f3f34 update notes, remove old comparison files
new ce01cf68ca fixup after rebase against main at
a254e50aae5487148e3a1a3f7dfe54ff5139f88b
new e8c39581d3 NO-JIRA some real debug I made with the new logging - just
squash with everything else
new be6fcb84f8 fixup after rebase to main at
3aeb24ae01f19a37d9378820a40d36624c28288b
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (ae15dfb251)
\
N -- N -- N refs/heads/new-logging (be6fcb84f8)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 127 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../artemis/api/core/management/RoleInfo.java | 26 ++-
artemis-docker/prepare-docker.sh | 31 ++-
.../protocol/amqp/broker/AmqpReadableBuffer.java | 227 -------------------
.../artemis/protocol/amqp/util/NettyReadable.java | 4 +-
.../protocol/amqp/util/NettyReadableTest.java | 4 +
.../core/protocol/mqtt/MQTTProtocolHandler.java | 29 ++-
.../mqtt/exceptions/InvalidClientIdException.java | 5 +-
.../management/impl/ActiveMQServerControlImpl.java | 14 +-
.../impl/LegacyLDAPSecuritySettingPlugin.java | 13 +-
artemis-website/package-lock.json | 4 +-
docs/user-manual/en/mqtt.md | 14 ++
examples/features/standard/camel/camel-war/pom.xml | 49 ++++-
pom.xml | 4 +-
.../management/ActiveMQServerControlTest.java | 91 +++++---
.../integration/mqtt/MQTTSecurityManagerTest.java | 28 +++
...gacyLDAPSecuritySettingPluginListenerTest2.java | 241 +++++++++++++++++++++
.../tests/integration/stomp/v11/StompV11Test.java | 18 +-
.../src/test/resources/AMQauth3.ldif | 113 ++++++++++
.../src/test/resources/login.config | 21 ++
tests/smoke-tests/pom.xml | 23 --
tests/soak-tests/pom.xml | 23 ++
.../main/resources/servers/mmfactory/broker.xml | 0
.../tests/soak/paging/M_and_M_FactoryTest.java} | 61 +++---
23 files changed, 679 insertions(+), 364 deletions(-)
delete mode 100644
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AmqpReadableBuffer.java
copy
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ActorListener.java
=>
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/exceptions/InvalidClientIdException.java
(85%)
create mode 100644
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/LegacyLDAPSecuritySettingPluginListenerTest2.java
create mode 100755 tests/integration-tests/src/test/resources/AMQauth3.ldif
rename tests/{smoke-tests =>
soak-tests}/src/main/resources/servers/mmfactory/broker.xml (100%)
rename
tests/{smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/mmfactory/MMSFactoryTest.java
=>
soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/paging/M_and_M_FactoryTest.java}
(93%)
