This is an automated email from the ASF dual-hosted git repository.
robbie pushed a change to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
discard 4ee9dd1343 Adding Step to verify if the broker has a log4j.properties
configuration. if it does not the broker will install one by default
discard 690fcbd60f Logging changes on BridgeImpl I used on real debug, squash
with everything else please
discard 9df85ce7c4 fix application of filtered version ref previously added in
logging docs
discard 0778b99a0c some more doc updates around monitorInterval
discard e81db19b8e add a 5sec monitorInterval to the default log4j2.properties
file, aligning with previous log config refresh behaviour. Update notes and
versions detail.
discard 6468df5056 fixup after rebase to main at
3aeb24ae01f19a37d9378820a40d36624c28288b
discard fd93a36b68 NO-JIRA some real debug I made with the new logging - just
squash with everything else
discard 6fc0b21e6d fixup after rebase against main at
a254e50aae5487148e3a1a3f7dfe54ff5139f88b
discard 309988e4ba update notes, remove old comparison files
discard db424cde03 remove arg that isnt being used anymore
discard 176259a5a5 add notes
discard 01a8ff9b54 try out simplifying to use auto-detected log4j2.properties
config file
discard 2d52f14cb3 repeat removal to undo compensating commits
discard 5bfb4b38c4 suppress unnecessary log4j2.properties file from console
war overlay files
discard 61f049d41f update documentation around logging
discard 8fa848dfa7 replace jbl reference with slf4j
discard 923eef8e6a add outline of details for versions.md to cover
discard c7715bae1c remove some remaining logging.properties files
discard 36e306b97c remove comparison logging-CI.properties file as the CI
specific config has gone away entirely
discard 94a59114ea update notes
discard c9176c03b7 remove examples config files that seem not to be referenced
anywhere, and reference things that dont seem to exist
discard bce4b4af53 restore comment
discard 2cb16b9e0d adjusting defaults
discard 890ff5c330 add note from some looking at the handling
discard cdfe2a0258 some consolidation and simplification of the processor to
make following easier and verification more consistent
discard 3f2edd73d9 Replacing JBL by slf4j on rest
discard 027f8b44ed Fix stacktraces of generated exceptions to not include the
generated logmessage method
discard 6c9b3953c8 WIP: fixups after rebase onto main at
11eab605842716487b0ca2cd5b019ba71bcc313d
discard 424162749d add note
discard d4f1cf65e3 action some TODOs, add some others
discard 1490a25738 some notes around reload
discard 88d09faca0 remove a couple TODOs not needed
discard b05418ea31 fixups after rebase to main at
a0f39a4b28545f4010e07d950c34fe9f1f228b68
discard 70a3af86c2 fixup header comments
discard 721dab238d fix some file references and update notes
discard b782e022d9 convert some more test loggers
discard 07e0fd2492 remove slf4j->jbl bridge from example
discard 8ba76346fd replace a couple of examples logging.properties that enable
audit logger output
discard 898bdff9c6 add a note
discard 10aafc24b7 remove exclusion that is no longer needed
discard c50a5ddb56 switch another logger missed previously
discard b1b3f9eadc fixups after rebase to main at
0ca44c0e6972991cf80e5feda34f6d02cf94dea0
discard 7b232fb9de remove uses of JBL from compatibility tests, add
artemis-unit-test-support to snapshots CP to ensure test appender class is
found and avoids stacktracing
discard cdfa451786 add another TODO note
discard 5b80a9122d move another old log config file out to root, for any later
comparisons needed
discard 5c26f2c470 replace logging.properties files for e2e-tests server
configs
discard aa762f25e4 remove commons-logging slf4j bridge now the karaf bits dont
cause beanutils log spam
discard d37db0d398 move karaf server feature test to its own module, its
logging deps mess with the commons-config handling
discard 910fb62026 delete old Log4J 1.x log4j.properties files that shouldnt
be doing anything, build isnt using log4j 1.x / reload4j anymore
discard ca8b28b1c8 update deps to match actual SLF4J base usage and simplify
discard 5f855fe8c2 use latest log4j version
discard 1ed1eb6be7 remove now-unused import
discard dff2ab3ff0 update notes
discard 94b96c6a37 remove rather than reinstate a couple of unnecesarry level
manipulations
discard 4c68b45d2b ensure method or class based cleanups for
AssertionLoggerHandler exist or will be effective, where startCapture() has
been called previously
discard 20874100c7 reinstate another test manipulating levels
discard 8e474d0ae1 restore one of the remaining tests using JBL, manipulating
levels
discard fc02aa2959 Revert "add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc"
discard 0702ebe892 Revert "Moving dependencies as test"
discard ad2e8f7fe9 Revert "Remove slf4j bridge depedencies from libs", towards
getting build back to consistent deps state and to more easily revert original
addition leading to issue.
discard d752a0fe87 fixing build after rebase
discard 8f6a40ecf3 Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
discard 6a6ccc6e3c fixing test
discard 69831c798c Moving dependencies as test
discard 8bc13575f4 Remove slf4j bridge depedencies from libs
discard ee75d81579 Removing log facade package
discard f427839ff3 make start on updating remaining integration tests,
manipulating levels etc
discard 83198117e5 remove various mentions of jblm and wildfly-common from
scripts etc, update service config logging details..now to see what it breaks
discard 5316c2ed80 also move the old main tests logging.config file
discard cc1263da5c move old base logging.properties out of artemis-cli, but
leave it in root for comparison to see needed config updates as others replaced
discard 8691fc0f5b add some TODOs for area cleanup still needed
discard 2754da6b0d change remaining integration tests except those with TODOs
discard 54c6bab4cd Adding safeguard against {?} on LogProcessor
discard cb8a7bd537 fix compile issues IDE somehow decided not to show
discard ae5f257564 more test changes
discard ac210a879c more test updates
discard 6590930280 some more integration test updates
discard 5425c08084 make start on updating integration tests
discard 41e852212e add note about e2e-test fixups needed
discard 93a4b6aa6f add artemis-unit-test-support dep to various modules that
have tests, avoid stacktrace on not finding appender from shared logging config
discard f56e72f7f7 Verifying JMX Security and setting up
javax.management.builder.initial before Log4J starts its own JMX
discard 5dd029faaa add artemis-unit-test-support dep to various modules that
have tests, and will stacktrace if the appender isnt found which is referenced
in their shared logging test config
discard ebca311a24 fix dep scope
discard 1bd71c3df2 add note about many integration-tests etc still using JBL
discard c2686f9bc2 fix other files similar to commit titled 'Fixing duplicate
properties'
discard 95f3826e68 Fixing duplicate properties
discard 1de056d9bc Setting version as 3.0.0
discard 13248675e6 updating version after rebasing
discard 1ad2e6a3e5 add log config to get NettyNativeTest working
discard 317c01321d simplify test logging config again, adjust assertion to be
more specific and take into account change in output from
07329118c10d14bce018a580b0dadbcf081233a8
discard 8c9b86e4ec add log config for AuditLoggerAMQPMutualSSLTest
discard 9c83af6663 ARTEMIS-3902 Adding Reason to Security Exception
discard 61ad231f91 add some TODO notes from memory
discard 9e63a03fbc add some [in-flux] config to get more failing audit log
smoke tests passing
discard 73532fb759 apply needed change only, and remove old unused
logging.properties file
discard 2c05cf25f3 reset smoke test config to current base assembly config
discard 296cb14574 some more helper additions to bring default assembly
logging config into line with prior config
discard c7f4f46ad6 Adding a test with no argument on exception (just to be
sure)
discard e6105c6e3c Removing @Cause annotation
discard e072f2a8b4 fix up errorprone error and an IDE warning
discard eff4b3a47a ensure exceptions/causes are the last arg passed, as the
logging framework expects, and processor now enforces
discard 7b8d1e6785 fix checkstyle on processor
discard 61aa2e39e2 small tweak on test
discard 9e483849c1 Enforcing exception as the last argument
discard 8ecd64951e log processing improvement with exceptions
discard 8829f9546e flesh out assembly default logging config, give output like
previous behaviour
discard fe1bc3cbb5 Removing Reload4J
discard 4e7b6f3cf2 fix some more placeholders missed previously
discard 6964057976 make basic start on audit log file config, add [unfinished]
config changes to get AuditLoggerResourceTest smoke test passing
discard 094c50edbb reorder args to match previously out-of-order placeholders,
ensure new output matches previous
discard 85d63027e6 remove now-unnecessary quote escaping from log/message
bundle format strings, giving same output as before switch to slf4j formatter
discard e6a8bd34f7 switch to released 2.0.0 artemis-native dep
discard 46513067d1 Fixing up some {0} versus {}
discard 4ca11231c2 re-enable GHA CI runs in the main repo, build now in state
it can pass the PR test subset (except for
d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it
fail)
discard afdcfb174c add TODO for another fun task
discard ff24950b37 fix various test failures due to unexpected message string;
also make some tests indicate why they failed
discard 17122a35bb temporarily remove test to allow concentrating on other
issues
discard 341d5039b4 fix test missed in prior change
discard d65a20353f fix format of code prefix in messages, pointed out by
failing test
discard 688b1e9ea8 make a start on a basic loging config for distribution
discard 9dee1af4a3 add some more needed deps; essentially every module with
tests (or without specific log test config) will need this to avoid a
stacktrace from logging setup issues
discard ee8d94f826 avoid NPE in a unit test due to audit loggers still being
enabled, unlike prior test logging config
discard 37c14b038d Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
discard 5cd29b1f68 add some deps needed/used already, look into test failure
discard 628119ba51 fixup for release profile following prior rebases+squashes
discard 964a7455c1 add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc
discard 531decd615 basic logging config and some more on
AssertionLoggerHandler to get some tests using it working
discard 7bb3507b37 make a start on restoring AssertionLoggerHandler to get
tests going
discard a9dee0703c Artemis native at 2.0 snapshot
discard d002007553 squashed logging changes from Clebert + me, rebased onto
main at 7bf1193380c8b15d8f5d0f14bd028e2380b104d6
discard 25f1ca5763 compensating commit, Revert "Bumping artemis as 3.0"
discard 25bb5e4975 comensating commit, Revert "ARTEMIS-3987 Removing ActiveMQ
Artemis Rest from the codebase."
add 9d20d7b87f NO-JIRA remove out-dated GC recommendation
add f0ff385c7c ARTEMIS-3962 porting changes from AMQ-9052
add f11b96e7ed ARTEMIS-3962 porting changes from AMQ-8613
add 8b56c04293 ARTEMIS-3962 porting changes from AMQ-5281
add 9a0669e282 This closes #4194
add 5e08540b8a ARTEMIS-3980 Drop website dependencies from
artemis-distribution
add 1974ec5289 This closes #4221
add d7d1c2ee42 ARTEMIS-4001 - add properties url to the reload manager
watch list, validate queue creation on reload with new test
add d8cdc24112 ARTEMIS-4005 - Fix e2e-test execution
add 3403f9a5ea This closes #4227
add dfa797f906 ARTEMIS-4006: remove repackaged/partial-shaded -all uber
client artifacts from the assembly
add 202a16b653 ARTEMIS-3970: update keycloak example to use 19.0.2
add 92964e4f00 ARTEMIS-3934 restore settings equivalent to
-XX:+AggressiveOpts
add 4ab947f2d9 ARTEMIS-4008: update to qpid-jms 1.7.0
new 7fb400a546 comensating commit, Revert "ARTEMIS-3987 Removing ActiveMQ
Artemis Rest from the codebase."
new 21a8df7b0b compensating commit, Revert "Bumping artemis as 3.0"
new 257684d9e8 squashed logging changes from Clebert + me, rebased onto
main at 4ab947f2d9142f40a0628c3136f2ab8f8e5104f9
new d3a6f0287c Artemis native at 2.0 snapshot
new ae0d8bded9 make a start on restoring AssertionLoggerHandler to get
tests going
new 6edb27ecd8 basic logging config and some more on
AssertionLoggerHandler to get some tests using it working
new 343e5a4969 add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc
new 3b6983b71f fixup for release profile following prior rebases+squashes
new a304d1eb00 add some deps needed/used already, look into test failure
new f0aa684bcf Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
new 39aee04298 avoid NPE in a unit test due to audit loggers still being
enabled, unlike prior test logging config
new d51fcf2079 add some more needed deps; essentially every module with
tests (or without specific log test config) will need this to avoid a
stacktrace from logging setup issues
new 4542e32a2b make a start on a basic loging config for distribution
new 782541539b fix format of code prefix in messages, pointed out by
failing test
new cfdb0d02d2 fix test missed in prior change
new 4f6d920dd4 temporarily remove test to allow concentrating on other
issues
new 4acd7d971e fix various test failures due to unexpected message string;
also make some tests indicate why they failed
new 847e64605f add TODO for another fun task
new 31ee32d48b re-enable GHA CI runs in the main repo, build now in state
it can pass the PR test subset (except for
d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it
fail)
new 24d45872b5 Fixing up some {0} versus {}
new d640244310 switch to released 2.0.0 artemis-native dep
new 885ec533ed remove now-unnecessary quote escaping from log/message
bundle format strings, giving same output as before switch to slf4j formatter
new a96407d09c reorder args to match previously out-of-order placeholders,
ensure new output matches previous
new 7117643170 make basic start on audit log file config, add [unfinished]
config changes to get AuditLoggerResourceTest smoke test passing
new 479ecb993a fix some more placeholders missed previously
new de7c4720d2 Removing Reload4J
new e02180fba6 flesh out assembly default logging config, give output like
previous behaviour
new 2cfe53275b log processing improvement with exceptions
new 49843fcad0 Enforcing exception as the last argument
new 8b08410ec0 small tweak on test
new 4c0ebaf3fb fix checkstyle on processor
new c35c2e64c1 ensure exceptions/causes are the last arg passed, as the
logging framework expects, and processor now enforces
new 4cb81b6025 fix up errorprone error and an IDE warning
new 9ddac06610 Removing @Cause annotation
new d3182fc90a Adding a test with no argument on exception (just to be
sure)
new c1d3cffd66 some more helper additions to bring default assembly
logging config into line with prior config
new 6cbb4bd0ed reset smoke test config to current base assembly config
new 5389dcf06b apply needed change only, and remove old unused
logging.properties file
new 19596297a1 add some [in-flux] config to get more failing audit log
smoke tests passing
new e24d92f461 add some TODO notes from memory
new 1769866d56 ARTEMIS-3902 Adding Reason to Security Exception
new bd31f72f8a add log config for AuditLoggerAMQPMutualSSLTest
new 4695733d1f simplify test logging config again, adjust assertion to be
more specific and take into account change in output from
07329118c10d14bce018a580b0dadbcf081233a8
new e951cb89cf add log config to get NettyNativeTest working
new 9db426665c updating version after rebasing
new d86294e634 Setting version as 3.0.0
new 187904ca95 Fixing duplicate properties
new 940e461504 fix other files similar to commit titled 'Fixing duplicate
properties'
new c8b73c92aa add note about many integration-tests etc still using JBL
new 6014cf0148 fix dep scope
new e02062bb12 add artemis-unit-test-support dep to various modules that
have tests, and will stacktrace if the appender isnt found which is referenced
in their shared logging test config
new 938355e5dc Verifying JMX Security and setting up
javax.management.builder.initial before Log4J starts its own JMX
new 743d3374c6 add artemis-unit-test-support dep to various modules that
have tests, avoid stacktrace on not finding appender from shared logging config
new 4a89ad7980 add note about e2e-test fixups needed
new e4ca3313b2 make start on updating integration tests
new 4560ccca38 some more integration test updates
new 382bc041af more test updates
new 4623dbadba more test changes
new 495dade97d fix compile issues IDE somehow decided not to show
new 0947226caf Adding safeguard against {?} on LogProcessor
new b901353bd9 change remaining integration tests except those with TODOs
new 2e85e807f6 add some TODOs for area cleanup still needed
new 5ff5829026 move old base logging.properties out of artemis-cli, but
leave it in root for comparison to see needed config updates as others replaced
new 1277a9146b also move the old main tests logging.config file
new 9914b9074d remove various mentions of jblm and wildfly-common from
scripts etc, update service config logging details..now to see what it breaks
new fe626a75ac make start on updating remaining integration tests,
manipulating levels etc
new 106c183383 Removing log facade package
new b1974ef59a Remove slf4j bridge depedencies from libs
new 5a44965ce3 Moving dependencies as test
new 4ffe8c54ff fixing test
new 51049315e3 Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
new 1417d31931 fixing build after rebase
new bc466d321b Revert "Remove slf4j bridge depedencies from libs", towards
getting build back to consistent deps state and to more easily revert original
addition leading to issue.
new 9c76c1768d Revert "Moving dependencies as test"
new 9ddd8209fa Revert "add commons-logging -> SLF4J bridge and exclude
commons-logging, suppresses unconfigured log spam from beanutils etc"
new f8acade5f3 restore one of the remaining tests using JBL, manipulating
levels
new 98ab4ba7d7 reinstate another test manipulating levels
new 8ce1467464 ensure method or class based cleanups for
AssertionLoggerHandler exist or will be effective, where startCapture() has
been called previously
new e17d524e1f remove rather than reinstate a couple of unnecesarry level
manipulations
new 25a4010026 update notes
new f26ded2d1f remove now-unused import
new d92832a08c use latest log4j version
new eba24c0cc1 update deps to match actual SLF4J base usage and simplify
new e8c92af141 delete old Log4J 1.x log4j.properties files that shouldnt
be doing anything, build isnt using log4j 1.x / reload4j anymore
new a55e29ee9a move karaf server feature test to its own module, its
logging deps mess with the commons-config handling
new ee57cfd0dc remove commons-logging slf4j bridge now the karaf bits dont
cause beanutils log spam
new 4ebc54e5cb replace logging.properties files for e2e-tests server
configs
new 40d345497a move another old log config file out to root, for any later
comparisons needed
new 8d11f51738 add another TODO note
new c6615fd169 remove uses of JBL from compatibility tests, add
artemis-unit-test-support to snapshots CP to ensure test appender class is
found and avoids stacktracing
new bc390d1324 fixups after rebase to main at
0ca44c0e6972991cf80e5feda34f6d02cf94dea0
new 203c870b9c switch another logger missed previously
new 1393cc311b remove exclusion that is no longer needed
new 1de76667f4 add a note
new 16605cd0a8 replace a couple of examples logging.properties that enable
audit logger output
new 8ba403dab0 remove slf4j->jbl bridge from example
new e9b369a80d convert some more test loggers
new 6939875628 fix some file references and update notes
new a4770530b5 fixup header comments
new 97872fedc6 fixups after rebase to main at
a0f39a4b28545f4010e07d950c34fe9f1f228b68
new 4b28251743 remove a couple TODOs not needed
new 08627625ef some notes around reload
new 17f541c53d action some TODOs, add some others
new 995f52681d add note
new 93470c49b1 WIP: fixups after rebase onto main at
11eab605842716487b0ca2cd5b019ba71bcc313d
new 566e365b9a Fix stacktraces of generated exceptions to not include the
generated logmessage method
new beb5a4d0c9 Replacing JBL by slf4j on rest
new aac2dd100e some consolidation and simplification of the processor to
make following easier and verification more consistent
new 68d77ba483 add note from some looking at the handling
new 217a5ccebb adjusting defaults
new 3c5705960f restore comment
new 464d0981a0 remove examples config files that seem not to be referenced
anywhere, and reference things that dont seem to exist
new a687a65ab0 update notes
new ba62362eda remove comparison logging-CI.properties file as the CI
specific config has gone away entirely
new 0eb293e0cd remove some remaining logging.properties files
new 4f05911a5f add outline of details for versions.md to cover
new e6b9ffef6b replace jbl reference with slf4j
new 0a95734090 update documentation around logging
new fd2b48b66e suppress unnecessary log4j2.properties file from console
war overlay files
new f4c03eec40 repeat removal to undo compensating commits
new 151184ab4d try out simplifying to use auto-detected log4j2.properties
config file
new 08d0b4703d add notes
new 300125b3b1 remove arg that isnt being used anymore
new 493604b1aa update notes, remove old comparison files
new 6293f3ebfe fixup after rebase against main at
a254e50aae5487148e3a1a3f7dfe54ff5139f88b
new c03b221456 NO-JIRA some real debug I made with the new logging - just
squash with everything else
new ffc1fb957a fixup after rebase to main at
3aeb24ae01f19a37d9378820a40d36624c28288b
new 319c1e28ce add a 5sec monitorInterval to the default log4j2.properties
file, aligning with previous log config refresh behaviour. Update notes and
versions detail.
new b18d3e9f82 some more doc updates around monitorInterval
new 322817f9e8 fix application of filtered version ref previously added in
logging docs
new 0faa7305f5 Logging changes on BridgeImpl I used on real debug, squash
with everything else please
new 64d188ba57 Adding Step to verify if the broker has a log4j.properties
configuration. if it does not the broker will install one by default
new b798d7bc75 Revert "Adding Step to verify if the broker has a
log4j.properties configuration. if it does not the broker will install one by
default"
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4ee9dd1343)
\
N -- N -- N refs/heads/new-logging (b798d7bc75)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 133 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../artemis/cli/commands/ActionAbstract.java | 23 ---
.../artemis/cli/commands/etc/artemis.profile | 2 +-
.../artemis/cli/commands/etc/artemis.profile.cmd | 2 +-
.../org/apache/activemq/cli/test/ArtemisTest.java | 19 ---
artemis-distribution/pom.xml | 27 ---
artemis-distribution/src/main/assembly/dep.xml | 16 --
.../selector/filter/ComparisonExpression.java | 28 +++
.../artemis/selector/filter/LogicExpression.java | 188 +++++++++++++++------
.../artemis/selector/filter/UnaryExpression.java | 10 ++
.../activemq/artemis/selector/MockMessage.java | 115 +++++++++++++
.../activemq/artemis/selector/SelectorTest.java | 101 +----------
.../selector/UnknownHandlingSelectorTest.java | 175 +++++++++++++++++++
.../artemis/core/config/Configuration.java | 4 +
.../core/config/CoreAddressConfiguration.java | 7 +
.../core/config/impl/ConfigurationImpl.java | 4 +-
.../cluster/impl/ClusterConnectionBridge.java | 24 +--
.../core/server/impl/ActiveMQServerImpl.java | 17 +-
.../core/server/reload/ReloadManagerImpl.java | 4 +-
.../artemis/core/filter/impl/FilterTest.java | 6 +
.../artemis/core/reload/ReloadManagerTest.java | 56 ++++++
docs/user-manual/en/client-classpath.md | 9 +-
docs/user-manual/en/perf-tuning.md | 4 -
.../features/standard/security-keycloak/pom.xml | 2 +-
pom.xml | 2 +-
tests/e2e-tests/pom.xml | 2 +-
.../integration/server/ConfigurationTest.java | 65 +++++++
26 files changed, 653 insertions(+), 259 deletions(-)
create mode 100644
artemis-selector/src/test/java/org/apache/activemq/artemis/selector/MockMessage.java
create mode 100644
artemis-selector/src/test/java/org/apache/activemq/artemis/selector/UnknownHandlingSelectorTest.java
