This is an automated email from the ASF dual-hosted git repository.
clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 2ffd94e682 ARTEMIS-4253 disabling a few
ActiveMQServerControlUsingCoreTest tests
2ffd94e682 is described below
commit 2ffd94e682d23a608f751044788cbf401841ed9b
Author: Clebert Suconic <[email protected]>
AuthorDate: Mon Apr 24 11:46:11 2023 -0400
ARTEMIS-4253 disabling a few ActiveMQServerControlUsingCoreTest tests
Some of these tests don't make sense when using the Core protocol due to
noise introduced
---
.../ActiveMQServerControlUsingCoreTest.java | 35 +++++++++++++++-------
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlUsingCoreTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlUsingCoreTest.java
index 068baaf607..45eaf155e7 100644
---
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlUsingCoreTest.java
+++
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlUsingCoreTest.java
@@ -22,8 +22,7 @@ import
org.apache.activemq.artemis.api.core.ActiveMQAddressDoesNotExistException
import org.apache.activemq.artemis.api.core.management.ActiveMQServerControl;
import org.apache.activemq.artemis.api.core.management.Parameter;
import org.apache.activemq.artemis.api.core.management.ResourceNames;
-import org.junit.Assume;
-import org.junit.Test;
+import org.junit.Ignore;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@@ -37,35 +36,51 @@ public class ActiveMQServerControlUsingCoreTest extends
ActiveMQServerControlTes
}
@Override
- @Test
+ @Ignore
public void testListProducersAgainstServer() throws Exception {
- // have to disable this test, as it's dealing with producers objects.
- // the test itself will be using a producer to manage the server.
- // so the test will include noise and it might fail occasionally
- Assume.assumeTrue(false);
+ // testListProducersAgainstServer is measuring the number of producers
in the server
+ // however the management controller itself will include producers
+ // what will introduce noise to the test
+ // hence this test needs to be ignored when using the core protocol for
management
}
- // ActiveMQServerControlTest overrides --------------------------
- // the core messaging proxy doesn't work when the server is stopped so we
cant run these 2 tests
+
+ @Ignore
+ @Override
+ public void testListSessions() throws Exception {
+ // similarly to testListProducersAgainstServer test,
+ // this test will have different objects created when running over core,
+ // what may introduce noise to the test
+ // for that reason this test is ignored on the UsingCoreTest
+ }
+
+ @Ignore
@Override
public void testScaleDownWithOutConnector() throws Exception {
+ // test would be invalid over core protocol
}
@Override
+ @Ignore
public void testScaleDownWithConnector() throws Exception {
+ // test would be invalid over core protocol
}
- // the proxy will not work on these tests, ignoring the tests
+ @Ignore
@Override
public void testRestartEmbeddedWebServerException() throws Exception {
+ // test would be invalid over core protocol
}
+ @Ignore
@Override
public void testRestartEmbeddedWebServerTimeout() throws Exception {
+ // test would be invalid over core protocol
}
+
@Override
protected ActiveMQServerControl createManagementControl() throws Exception {
return new ActiveMQServerControl() {
