This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new c7f28ad70b ARTEMIS-4290 Isolating more threads, removing 
disableThreadChecks
c7f28ad70b is described below

commit c7f28ad70b9d204e18413a30060e238d1e8f8e06
Author: Clebert Suconic <clebertsuco...@apache.org>
AuthorDate: Wed May 24 09:50:47 2023 -0400

    ARTEMIS-4290 Isolating more threads, removing disableThreadChecks
---
 tests/e2e-tests/pom.xml                                               | 1 +
 .../activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java | 4 ----
 .../jms/multiprotocol/MultiprotocolJMSClientTestSupport.java          | 4 ----
 tests/smoke-tests/pom.xml                                             | 2 ++
 tests/soak-tests/pom.xml                                              | 1 +
 5 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/tests/e2e-tests/pom.xml b/tests/e2e-tests/pom.xml
index c4bb59a272..b369f81dd9 100644
--- a/tests/e2e-tests/pom.xml
+++ b/tests/e2e-tests/pom.xml
@@ -326,6 +326,7 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
+               <forkMode>always</forkMode>
                <skipTests>${e2e-tests.skipTests}</skipTests>
                <argLine>${e2e-tests.surefire-extra-args} 
${activemq-surefire-argline} ${container-service-argline}</argLine>
             </configuration>
diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java
index 4f202af0d0..61c2db9ce4 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java
@@ -42,10 +42,6 @@ public abstract class JMSClientTestSupport extends 
AmqpClientTestSupport {
    @Override
    public void setUp() throws Exception {
       super.setUp();
-
-      // Bug in Qpid JMS not shutting down a connection thread on certain 
errors
-      // TODO - Reevaluate after Qpid JMS 0.23.0 is released.
-      disableCheckThread();
    }
 
    @After
diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/MultiprotocolJMSClientTestSupport.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/MultiprotocolJMSClientTestSupport.java
index c4eb134469..8088d67e8d 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/MultiprotocolJMSClientTestSupport.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/MultiprotocolJMSClientTestSupport.java
@@ -81,10 +81,6 @@ public abstract class MultiprotocolJMSClientTestSupport 
extends ActiveMQTestBase
    public void setUp() throws Exception {
       super.setUp();
 
-      // Bug in Qpid JMS not shutting down a connection thread on certain 
errors
-      // TODO - Reevaluate after Qpid JMS 0.23.0 is released.
-      disableCheckThread();
-
       server = createServer();
    }
 
diff --git a/tests/smoke-tests/pom.xml b/tests/smoke-tests/pom.xml
index 29607ee4d7..31fedd979e 100644
--- a/tests/smoke-tests/pom.xml
+++ b/tests/smoke-tests/pom.xml
@@ -1321,6 +1321,7 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
+               <forkMode>always</forkMode>
                <skipTests>${skipSmokeTests}</skipTests>
                <argLine>${sts-surefire-extra-args} 
${activemq-surefire-argline} ${artemis-distribuiton-lib-dir}</argLine>
             </configuration>
@@ -1349,6 +1350,7 @@
                      <groupId>org.apache.maven.plugins</groupId>
                      <artifactId>maven-surefire-plugin</artifactId>
                      <configuration>
+                        <forkMode>always</forkMode>
                         <includes combine.children="override">
                            <include>**/smoke/upgradeTest/*Test.java</include>
                         </includes>
diff --git a/tests/soak-tests/pom.xml b/tests/soak-tests/pom.xml
index b67887cbe7..f2cdcef7ef 100644
--- a/tests/soak-tests/pom.xml
+++ b/tests/soak-tests/pom.xml
@@ -494,6 +494,7 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
+               <forkMode>always</forkMode>
                <skipTests>${skipSoakTests}</skipTests>
                <includes>
                   <include>**/*Test.java</include>

Reply via email to