[activemq-artemis] branch main updated: ARTEMIS-4467 Core client code visibility change required.

[clebertsuconic]

This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 37273701ea ARTEMIS-4467 Core client code visibility change required.
37273701ea is described below

commit 37273701ea155b21c190341b397258abdcfaa5db
Author: Emmanuel Hugonnet <ehugo...@redhat.com>
AuthorDate: Mon Oct 23 17:15:50 2023 +0200

    ARTEMIS-4467 Core client code visibility change required.
    
    * Since the constructors in RemotingConnectionImpl can be used from the 
server and the client.
    If the server calling code is in a different classloader then the
    constructor can't be called.
    * same for the 'active' boolean property of ActiveMQChannelHandler
    
    Issue: https://issues.apache.org/jira/browse/ARTEMIS-4467
    
    Signed-off-by: Emmanuel Hugonnet <ehugo...@redhat.com>
---
 .../artemis/core/protocol/core/impl/RemotingConnectionImpl.java         | 2 +-
 .../artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
index bf6788f79c..af619378e3 100644
--- 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
+++ 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
@@ -96,7 +96,7 @@ public class RemotingConnectionImpl extends 
AbstractRemotingConnection implement
    /*
     * Create a server side connection
     */
-   RemotingConnectionImpl(final PacketDecoder packetDecoder,
+   public RemotingConnectionImpl(final PacketDecoder packetDecoder,
                           final Connection transportConnection,
                           final List<Interceptor> incomingInterceptors,
                           final List<Interceptor> outgoingInterceptors,
diff --git 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java
 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java
index acd314ce92..fceac5ce2a 100644
--- 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java
+++ 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java
@@ -40,7 +40,7 @@ public class ActiveMQChannelHandler extends 
ChannelDuplexHandler {
 
    private final BaseConnectionLifeCycleListener<?> listener;
 
-   volatile boolean active;
+   protected volatile boolean active;
 
    private final Executor listenerExecutor;