This is an automated email from the ASF dual-hosted git repository. jbertram pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
commit bc86a0a481879542525cb18243d23f51e3ae833d Author: aslepykh <[email protected]> AuthorDate: Thu Feb 29 10:00:54 2024 +0300 ARTEMIS-4695 BAD_COPY_PASTE in ActiveMQScheduledLeaseLock.java In the detectAndReportRenewSlowness() method, the logger.error() and logger.warn() methods are called 3 times. In two of the three calls, the method arguments correspond to parameters that are tested in the if() conditional construct. Also, the arguments of the logger.error() and logger.warn() methods are identical in lines 139 and 141, respectively, which may indicate that they were copied incorrectly. --- .../artemis/core/server/impl/jdbc/ActiveMQScheduledLeaseLock.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/ActiveMQScheduledLeaseLock.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/ActiveMQScheduledLeaseLock.java index a4d8b81262..523df09943 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/ActiveMQScheduledLeaseLock.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/ActiveMQScheduledLeaseLock.java @@ -136,7 +136,7 @@ final class ActiveMQScheduledLeaseLock extends ActiveMQScheduledComponent implem final long measuredRenewPeriodNanos = renewStart - lastRenewStart; final long measuredRenewPeriodMillis = TimeUnit.NANOSECONDS.toMillis(measuredRenewPeriodNanos); if (measuredRenewPeriodMillis - expirationMillis > 100) { - logger.error("{} lock {} renew period lasted {} ms instead of {} ms", lockName, lostLock ? "failed" : "successful", measuredRenewPeriodMillis, expectedRenewPeriodMillis); + logger.error("{} lock {} renew period lasted {} ms instead of {} ms", lockName, lostLock ? "failed" : "successful", measuredRenewPeriodMillis, expirationMillis); } else if (measuredRenewPeriodMillis - expectedRenewPeriodMillis > 100) { logger.warn("{} lock {} renew period lasted {} ms instead of {} ms", lockName, lostLock ? "failed" : "successful", measuredRenewPeriodMillis, expectedRenewPeriodMillis); }
