This is an automated email from the ASF dual-hosted git repository.

tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 220a5ae2aa ARTEMIS-4796 add tests & remove refs
220a5ae2aa is described below

commit 220a5ae2aa176d19185b6f3ec41b24b6f04e0c6f
Author: Justin Bertram <[email protected]>
AuthorDate: Fri Jun 7 16:08:28 2024 -0500

    ARTEMIS-4796 add tests & remove refs
---
 .../tests/util/DeprecatedApiSimpleStringTest.java  |  32 ++++++
 .../artemis/tests/util/SimpleStringTest.java       | 120 +++++++++++----------
 .../tests/integration/server/QueueQueryTest.java   |   4 +-
 .../stomp/StompWithLargeMessagesTest.java          |   2 +-
 .../tests/performance/jmh/AddressMapPerfTest.java  |   2 +-
 .../performance/jmh/DuplicateIDCacheBenchmark.java |   4 +-
 .../WildcardAddressManagerHeirarchyPerfTest.java   |  12 +--
 .../jmh/WildcardAddressManagerPerfTest.java        |   8 +-
 8 files changed, 111 insertions(+), 73 deletions(-)

diff --git 
a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/DeprecatedApiSimpleStringTest.java
 
b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/DeprecatedApiSimpleStringTest.java
new file mode 100644
index 0000000000..643517f477
--- /dev/null
+++ 
b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/DeprecatedApiSimpleStringTest.java
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.util;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+
+public class DeprecatedApiSimpleStringTest extends SimpleStringTest {
+
+   @Override
+   protected SimpleString createSimpleString(String string) {
+      return new SimpleString(string);
+   }
+
+   @Override
+   protected SimpleString createSimpleString(byte[] bytes) {
+      return new SimpleString(bytes);
+   }
+}
diff --git 
a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/SimpleStringTest.java
 
b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/SimpleStringTest.java
index a2cac17e64..9866e9b44b 100644
--- 
a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/SimpleStringTest.java
+++ 
b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/SimpleStringTest.java
@@ -46,12 +46,12 @@ public class SimpleStringTest {
     */
    @Test
    public void testGetChar() {
-      SimpleString p1 = SimpleString.of("foo");
-      SimpleString p2 = SimpleString.of("bar");
+      SimpleString p1 = createSimpleString("foo");
+      SimpleString p2 = createSimpleString("bar");
       for (int i = 0; i < 1 << 16; i++) {
          String msg = "expecting " + i;
          char c = (char) i;
-         SimpleString s = SimpleString.of(String.valueOf(c));
+         SimpleString s = createSimpleString(String.valueOf(c));
 
          // test getChars(...)
          char[] c1 = new char[1];
@@ -66,7 +66,7 @@ public class SimpleStringTest {
          assertEquals(c, s2.charAt(1), msg);
 
          // test splitting with chars
-         SimpleString sSplit = SimpleString.of("foo" + String.valueOf(c) + 
"bar");
+         SimpleString sSplit = createSimpleString("foo" + String.valueOf(c) + 
"bar");
          SimpleString[] chunks = sSplit.split(c);
          SimpleString[] split1 = p1.split(c);
          SimpleString[] split2 = p2.split(c);
@@ -86,7 +86,7 @@ public class SimpleStringTest {
    public void testString() throws Exception {
       final String str = 
"hello123ABC__524`16254`6125!%^$!%$!%$!%$!%!$%!$$!\uA324";
 
-      SimpleString s = SimpleString.of(str);
+      SimpleString s = createSimpleString(str);
 
       assertEquals(str, s.toString());
 
@@ -94,32 +94,32 @@ public class SimpleStringTest {
 
       byte[] data = s.getData();
 
-      SimpleString s2 = SimpleString.of(data);
+      SimpleString s2 = createSimpleString(data);
 
       assertEquals(str, s2.toString());
    }
 
    @Test
    public void testStartsWith() throws Exception {
-      SimpleString s1 = SimpleString.of("abcdefghi");
+      SimpleString s1 = createSimpleString("abcdefghi");
 
-      assertTrue(s1.startsWith(SimpleString.of("abc")));
+      assertTrue(s1.startsWith(createSimpleString("abc")));
 
-      assertTrue(s1.startsWith(SimpleString.of("abcdef")));
+      assertTrue(s1.startsWith(createSimpleString("abcdef")));
 
-      assertTrue(s1.startsWith(SimpleString.of("abcdefghi")));
+      assertTrue(s1.startsWith(createSimpleString("abcdefghi")));
 
-      assertFalse(s1.startsWith(SimpleString.of("abcdefghijklmn")));
+      assertFalse(s1.startsWith(createSimpleString("abcdefghijklmn")));
 
-      assertFalse(s1.startsWith(SimpleString.of("aardvark")));
+      assertFalse(s1.startsWith(createSimpleString("aardvark")));
 
-      assertFalse(s1.startsWith(SimpleString.of("z")));
+      assertFalse(s1.startsWith(createSimpleString("z")));
    }
 
    @Test
    public void testCharSequence() throws Exception {
       String s = "abcdefghijkl";
-      SimpleString s1 = SimpleString.of(s);
+      SimpleString s1 = createSimpleString(s);
 
       assertEquals('a', s1.charAt(0));
       assertEquals('b', s1.charAt(1));
@@ -162,13 +162,13 @@ public class SimpleStringTest {
       assertEquals(ss, s1);
 
       ss = s1.subSequence(1, 4);
-      assertEquals(ss, SimpleString.of("bcd"));
+      assertEquals(ss, createSimpleString("bcd"));
 
       ss = s1.subSequence(5, 10);
-      assertEquals(ss, SimpleString.of("fghij"));
+      assertEquals(ss, createSimpleString("fghij"));
 
       ss = s1.subSequence(5, 12);
-      assertEquals(ss, SimpleString.of("fghijkl"));
+      assertEquals(ss, createSimpleString("fghijkl"));
 
       try {
          s1.subSequence(-1, 2);
@@ -208,21 +208,21 @@ public class SimpleStringTest {
 
    @Test
    public void testEquals() throws Exception {
-      assertFalse(SimpleString.of("abcdef").equals(new Object()));
+      assertFalse(createSimpleString("abcdef").equals(new Object()));
 
-      assertFalse(SimpleString.of("abcef").equals(null));
+      assertFalse(createSimpleString("abcef").equals(null));
 
-      assertEquals(SimpleString.of("abcdef"), SimpleString.of("abcdef"));
+      assertEquals(createSimpleString("abcdef"), createSimpleString("abcdef"));
 
-      
assertFalse(SimpleString.of("abcdef").equals(SimpleString.of("abggcdef")));
-      assertFalse(SimpleString.of("abcdef").equals(SimpleString.of("ghijkl")));
+      
assertFalse(createSimpleString("abcdef").equals(createSimpleString("abggcdef")));
+      
assertFalse(createSimpleString("abcdef").equals(createSimpleString("ghijkl")));
    }
 
    @Test
    public void testHashcode() throws Exception {
-      SimpleString str = SimpleString.of("abcdef");
-      SimpleString sameStr = SimpleString.of("abcdef");
-      SimpleString differentStr = SimpleString.of("ghijk");
+      SimpleString str = createSimpleString("abcdef");
+      SimpleString sameStr = createSimpleString("abcdef");
+      SimpleString differentStr = createSimpleString("ghijk");
 
       assertTrue(str.hashCode() == sameStr.hashCode());
       assertFalse(str.hashCode() == differentStr.hashCode());
@@ -232,9 +232,9 @@ public class SimpleStringTest {
    public void testUnicode() throws Exception {
       String myString = 
"abcdef&^*&!^ghijkl\uB5E2\uCAC7\uB2BB\uB7DD\uB7C7\uB3A3\uBCE4\uB5A5";
 
-      SimpleString s = SimpleString.of(myString);
+      SimpleString s = createSimpleString(myString);
       byte[] data = s.getData();
-      s = SimpleString.of(data);
+      s = createSimpleString(data);
 
       assertEquals(myString, s.toString());
    }
@@ -243,18 +243,18 @@ public class SimpleStringTest {
    public void testUnicodeWithSurrogates() throws Exception {
       String myString = "abcdef&^*&!^ghijkl\uD900\uDD00";
 
-      SimpleString s = SimpleString.of(myString);
+      SimpleString s = createSimpleString(myString);
       byte[] data = s.getData();
-      s = SimpleString.of(data);
+      s = createSimpleString(data);
 
       assertEquals(myString, s.toString());
    }
 
    @Test
    public void testSizeofString() throws Exception {
-      assertEquals(DataConstants.SIZE_INT, 
SimpleString.sizeofString(SimpleString.of("")));
+      assertEquals(DataConstants.SIZE_INT, 
SimpleString.sizeofString(createSimpleString("")));
 
-      SimpleString str = SimpleString.of(RandomUtil.randomString());
+      SimpleString str = createSimpleString(RandomUtil.randomString());
       assertEquals(DataConstants.SIZE_INT + str.getData().length, 
SimpleString.sizeofString(str));
    }
 
@@ -262,15 +262,15 @@ public class SimpleStringTest {
    public void testSizeofNullableString() throws Exception {
       assertEquals(1, SimpleString.sizeofNullableString(null));
 
-      assertEquals(1 + DataConstants.SIZE_INT, 
SimpleString.sizeofNullableString(SimpleString.of("")));
+      assertEquals(1 + DataConstants.SIZE_INT, 
SimpleString.sizeofNullableString(createSimpleString("")));
 
-      SimpleString str = SimpleString.of(RandomUtil.randomString());
+      SimpleString str = createSimpleString(RandomUtil.randomString());
       assertEquals(1 + DataConstants.SIZE_INT + str.getData().length, 
SimpleString.sizeofNullableString(str));
    }
 
    @Test
    public void testSplitNoDelimeter() throws Exception {
-      SimpleString s = SimpleString.of("abcdefghi");
+      SimpleString s = createSimpleString("abcdefghi");
       SimpleString[] strings = s.split('.');
       assertNotNull(strings);
       assertEquals(strings.length, 1);
@@ -279,31 +279,31 @@ public class SimpleStringTest {
 
    @Test
    public void testSplit1Delimeter() throws Exception {
-      SimpleString s = SimpleString.of("abcd.efghi");
+      SimpleString s = createSimpleString("abcd.efghi");
       SimpleString[] strings = s.split('.');
       assertNotNull(strings);
       assertEquals(strings.length, 2);
-      assertEquals(strings[0], SimpleString.of("abcd"));
-      assertEquals(strings[1], SimpleString.of("efghi"));
+      assertEquals(strings[0], createSimpleString("abcd"));
+      assertEquals(strings[1], createSimpleString("efghi"));
    }
 
    @Test
    public void testSplitmanyDelimeters() throws Exception {
-      SimpleString s = SimpleString.of("abcd.efghi.jklmn.opqrs.tuvw.xyz");
+      SimpleString s = createSimpleString("abcd.efghi.jklmn.opqrs.tuvw.xyz");
       SimpleString[] strings = s.split('.');
       assertNotNull(strings);
       assertEquals(strings.length, 6);
-      assertEquals(strings[0], SimpleString.of("abcd"));
-      assertEquals(strings[1], SimpleString.of("efghi"));
-      assertEquals(strings[2], SimpleString.of("jklmn"));
-      assertEquals(strings[3], SimpleString.of("opqrs"));
-      assertEquals(strings[4], SimpleString.of("tuvw"));
-      assertEquals(strings[5], SimpleString.of("xyz"));
+      assertEquals(strings[0], createSimpleString("abcd"));
+      assertEquals(strings[1], createSimpleString("efghi"));
+      assertEquals(strings[2], createSimpleString("jklmn"));
+      assertEquals(strings[3], createSimpleString("opqrs"));
+      assertEquals(strings[4], createSimpleString("tuvw"));
+      assertEquals(strings[5], createSimpleString("xyz"));
    }
 
    @Test
    public void testContains() {
-      SimpleString simpleString = SimpleString.of("abcdefghijklmnopqrst");
+      SimpleString simpleString = createSimpleString("abcdefghijklmnopqrst");
       assertFalse(simpleString.contains('.'));
       assertFalse(simpleString.contains('%'));
       assertFalse(simpleString.contains('8'));
@@ -332,14 +332,14 @@ public class SimpleStringTest {
 
    @Test
    public void testConcat() {
-      SimpleString start = SimpleString.of("abcdefg");
-      SimpleString middle = SimpleString.of("hijklmnop");
-      SimpleString end = SimpleString.of("qrstuvwxyz");
-      assertEquals(start.concat(middle).concat(end), 
SimpleString.of("abcdefghijklmnopqrstuvwxyz"));
-      assertEquals(start.concat('.').concat(end), 
SimpleString.of("abcdefg.qrstuvwxyz"));
+      SimpleString start = createSimpleString("abcdefg");
+      SimpleString middle = createSimpleString("hijklmnop");
+      SimpleString end = createSimpleString("qrstuvwxyz");
+      assertEquals(start.concat(middle).concat(end), 
createSimpleString("abcdefghijklmnopqrstuvwxyz"));
+      assertEquals(start.concat('.').concat(end), 
createSimpleString("abcdefg.qrstuvwxyz"));
       // Testing concat of SimpleString with String
       for (int i = 0; i < 10; i++) {
-         assertEquals(SimpleString.of("abcdefg-" + i), start.concat("-" + 
Integer.toString(i)));
+         assertEquals(createSimpleString("abcdefg-" + i), start.concat("-" + 
Integer.toString(i)));
 
       }
    }
@@ -355,9 +355,9 @@ public class SimpleStringTest {
          }
          String strvalue = buffer.toString();
 
-         final int initialhash = SimpleString.of(strvalue).hashCode();
+         final int initialhash = createSimpleString(strvalue).hashCode();
 
-         final SimpleString value = SimpleString.of(strvalue);
+         final SimpleString value = createSimpleString(strvalue);
 
          int nThreads = 100;
          final CountDownLatch latch = new CountDownLatch(nThreads);
@@ -407,7 +407,7 @@ public class SimpleStringTest {
    @Test
    public void testToSimpleStringPoolStringArgument() throws Exception {
       final String s = "pooled";
-      final SimpleString ss = SimpleString.of(s);
+      final SimpleString ss = createSimpleString(s);
       final String s1 = ss.toString();
       assertSame(s, s1, "SimpleString::toSimpleString is not pooling the given 
String");
    }
@@ -417,10 +417,10 @@ public class SimpleStringTest {
       final int capacity = 8;
       final int chars = Integer.toString(capacity).length();
       final SimpleString.ByteBufSimpleStringPool pool = new 
SimpleString.ByteBufSimpleStringPool(capacity, chars);
-      final int bytes = SimpleString.of(Integer.toString(capacity)).sizeof();
+      final int bytes = 
createSimpleString(Integer.toString(capacity)).sizeof();
       final ByteBuf bb = Unpooled.buffer(bytes, bytes);
       for (int i = 0; i < capacity; i++) {
-         final SimpleString s = SimpleString.of(Integer.toString(i));
+         final SimpleString s = createSimpleString(Integer.toString(i));
          bb.resetWriterIndex();
          SimpleString.writeSimpleString(bb, s);
          bb.resetReaderIndex();
@@ -433,7 +433,7 @@ public class SimpleStringTest {
 
    @Test
    public void testByteBufSimpleStringPoolTooLong() {
-      final SimpleString tooLong = SimpleString.of("aa");
+      final SimpleString tooLong = createSimpleString("aa");
       final ByteBuf bb = Unpooled.buffer(tooLong.sizeof(), tooLong.sizeof());
       SimpleString.writeSimpleString(bb, tooLong);
       final SimpleString.ByteBufSimpleStringPool pool = new 
SimpleString.ByteBufSimpleStringPool(1, tooLong.length() - 1);
@@ -451,5 +451,11 @@ public class SimpleStringTest {
       }
    }
 
+   protected SimpleString createSimpleString(String string) {
+      return SimpleString.of(string);
+   }
 
+   protected SimpleString createSimpleString(byte[] bytes) {
+      return SimpleString.of(bytes);
+   }
 }
diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/QueueQueryTest.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/QueueQueryTest.java
index 4e35163ca1..63376d37b4 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/QueueQueryTest.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/QueueQueryTest.java
@@ -79,8 +79,8 @@ public class QueueQueryTest extends ActiveMQTestBase {
 
    @Test
    public void testQueueQueryOnStaticQueueWithFQQN() throws Exception {
-//      SimpleString addressName = 
SimpleString.toSimpleString(UUID.randomUUID().toString());
-//      SimpleString queueName = 
SimpleString.toSimpleString(UUID.randomUUID().toString());
+//      SimpleString addressName = 
SimpleString.of(UUID.randomUUID().toString());
+//      SimpleString queueName = SimpleString.of(UUID.randomUUID().toString());
       SimpleString addressName = SimpleString.of("myAddress");
       SimpleString queueName = SimpleString.of("myQueue");
       SimpleString fqqn = addressName.concat("::").concat(queueName);
diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompWithLargeMessagesTest.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompWithLargeMessagesTest.java
index 1cfe6fb6fe..e1a1e40d35 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompWithLargeMessagesTest.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompWithLargeMessagesTest.java
@@ -391,7 +391,7 @@ public class StompWithLargeMessagesTest extends 
StompTestBase {
 //         this.sendJmsMessage(msg);
 //      }
 //
-//      IntegrationTestLogger.LOGGER.info("Message count for {}: {}", 
getQueueName(), 
server.getActiveMQServer().locateQueue(SimpleString.toSimpleString(getQueueName())).getMessageCount());
+//      IntegrationTestLogger.LOGGER.info("Message count for {}: {}", 
getQueueName(), 
server.getActiveMQServer().locateQueue(SimpleString.of(getQueueName())).getMessageCount());
 //
 //      StompClientConnection connV12 = 
StompClientConnectionFactory.createClientConnection("1.2", hostname, port);
 //      connV12.connect(defUser, defPass);
diff --git 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/AddressMapPerfTest.java
 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/AddressMapPerfTest.java
index f21298909e..7078a171d7 100644
--- 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/AddressMapPerfTest.java
+++ 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/AddressMapPerfTest.java
@@ -61,7 +61,7 @@ public class AddressMapPerfTest {
       entries = 1 << entriesLog2;
       keys = new SimpleString[entries];
       for (int i = 0; i < entries; i++) {
-         keys[i] = SimpleString.toSimpleString("topic." + i % entriesLog2 + 
"." + i);
+         keys[i] = SimpleString.of("topic." + i % entriesLog2 + "." + i);
       }
    }
 
diff --git 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/DuplicateIDCacheBenchmark.java
 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/DuplicateIDCacheBenchmark.java
index 0917267a49..7ca4520af0 100644
--- 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/DuplicateIDCacheBenchmark.java
+++ 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/DuplicateIDCacheBenchmark.java
@@ -55,8 +55,8 @@ public class DuplicateIDCacheBenchmark {
    @Setup
    public void init() throws Exception {
       cache = persist ?
-         
DuplicateIDCaches.persistent(SimpleString.toSimpleString("benchmark"), size, 
new NullStorageManager()) :
-         DuplicateIDCaches.inMemory(SimpleString.toSimpleString("benchmark"), 
size);
+         DuplicateIDCaches.persistent(SimpleString.of("benchmark"), size, new 
NullStorageManager()) :
+         DuplicateIDCaches.inMemory(SimpleString.of("benchmark"), size);
       final int idSize = findNextHigherPowerOf2(size);
       idsMask = idSize - 1;
       nextId = 0;
diff --git 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerHeirarchyPerfTest.java
 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerHeirarchyPerfTest.java
index 8b791146f7..88a473fff2 100644
--- 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerHeirarchyPerfTest.java
+++ 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerHeirarchyPerfTest.java
@@ -183,12 +183,12 @@ public class WildcardAddressManagerHeirarchyPerfTest {
 
          if (verifyWildcardBinding) {
             // ensure simple matches present
-            addresses[i] = 
SimpleString.toSimpleString(MessageFormat.format("Topic1.abc-{0}.def-{0}.{1}", 
i % partitions, i));
-            addressManager.addBinding(new BindingFake(addresses[i], 
SimpleString.toSimpleString("" + i), i));
+            addresses[i] = 
SimpleString.of(MessageFormat.format("Topic1.abc-{0}.def-{0}.{1}", i % 
partitions, i));
+            addressManager.addBinding(new BindingFake(addresses[i], 
SimpleString.of("" + i), i));
          } else {
             // ensure wildcard matches present
-            addresses[i] = 
SimpleString.toSimpleString(MessageFormat.format("Topic1.abc-{0}.*.{1}", i % 
partitions, i));
-            addressManager.addBinding(new BindingFake(addresses[i], 
SimpleString.toSimpleString("" + i), i));
+            addresses[i] = 
SimpleString.of(MessageFormat.format("Topic1.abc-{0}.*.{1}", i % partitions, 
i));
+            addressManager.addBinding(new BindingFake(addresses[i], 
SimpleString.of("" + i), i));
 
          }
       }
@@ -213,9 +213,9 @@ public class WildcardAddressManagerHeirarchyPerfTest {
          final long id = benchmarkState.nextId();
          addresses = benchmarkState.addresses;
          if (benchmarkState.verifyWildcardBinding) {
-            binding = new 
BindingFake(SimpleString.toSimpleString(MessageFormat.format("Topic1.abc-{0}.def-{1}.>",
 id % benchmarkState.partitions, id)), SimpleString.toSimpleString("" + id), 
id);
+            binding = new 
BindingFake(SimpleString.of(MessageFormat.format("Topic1.abc-{0}.def-{1}.>", id 
% benchmarkState.partitions, id)), SimpleString.of("" + id), id);
          } else {
-            binding = new 
BindingFake(SimpleString.toSimpleString(MessageFormat.format("Topic1.abc-{0}.def-{0}.{1}",
 id % benchmarkState.partitions, id)), SimpleString.toSimpleString("" + id), 
id);
+            binding = new 
BindingFake(SimpleString.of(MessageFormat.format("Topic1.abc-{0}.def-{0}.{1}", 
id % benchmarkState.partitions, id)), SimpleString.of("" + id), id);
          }
       }
 
diff --git 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerPerfTest.java
 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerPerfTest.java
index 3fe51c4b4b..cd443a1ad0 100644
--- 
a/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerPerfTest.java
+++ 
b/tests/performance-jmh/src/main/java/org/apache/activemq/artemis/tests/performance/jmh/WildcardAddressManagerPerfTest.java
@@ -168,7 +168,7 @@ public class WildcardAddressManagerPerfTest {
       WILDCARD_CONFIGURATION.setAnyWords('>');
    }
 
-   private static final SimpleString WILDCARD = 
SimpleString.toSimpleString("Topic1.>");
+   private static final SimpleString WILDCARD = SimpleString.of("Topic1.>");
 
    @Setup
    public void init() throws Exception {
@@ -179,9 +179,9 @@ public class WildcardAddressManagerPerfTest {
       topics = 1 << topicsLog2;
       addresses = new SimpleString[topics];
       for (int i = 0; i < topics; i++) {
-         Binding binding = new BindingFake(WILDCARD, 
SimpleString.toSimpleString("" + i), i);
+         Binding binding = new BindingFake(WILDCARD, SimpleString.of("" + i), 
i);
          addressManager.addBinding(binding);
-         addresses[i] = SimpleString.toSimpleString("Topic1." + i);
+         addresses[i] = SimpleString.of("Topic1." + i);
          addressManager.getBindingsForRoutingAddress(addresses[i]);
       }
       topicCounter = new AtomicLong(0);
@@ -202,7 +202,7 @@ public class WildcardAddressManagerPerfTest {
       @Setup
       public void init(WildcardAddressManagerPerfTest benchmarkState) {
          final long id = benchmarkState.nextId();
-         binding = new BindingFake(WILDCARD, SimpleString.toSimpleString("" + 
id), id);
+         binding = new BindingFake(WILDCARD, SimpleString.of("" + id), id);
          addresses = benchmarkState.addresses;
       }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to