This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new f6cd61defc NO-JIRA making BackupSyncLargeMessageTest more reliable
f6cd61defc is described below

commit f6cd61defcf45a41f08de1ab9b302791affe031c
Author: Clebert Suconic <[email protected]>
AuthorDate: Thu Apr 3 15:55:24 2025 -0400

    NO-JIRA making BackupSyncLargeMessageTest more reliable
---
 .../failover/BackupSyncLargeMessageTest.java       | 27 ++++++++++++++--------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncLargeMessageTest.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncLargeMessageTest.java
index ad3640a18f..433c0aeb2a 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncLargeMessageTest.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncLargeMessageTest.java
@@ -19,7 +19,6 @@ package 
org.apache.activemq.artemis.tests.integration.cluster.failover;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.File;
 import java.util.Set;
@@ -38,6 +37,7 @@ import 
org.apache.activemq.artemis.api.core.client.ClientProducer;
 import org.apache.activemq.artemis.api.core.client.ClientSession;
 import org.apache.activemq.artemis.core.client.impl.ServerLocatorInternal;
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.utils.RandomUtil;
 import org.junit.jupiter.api.Test;
 
 public class BackupSyncLargeMessageTest extends BackupSyncJournalTest {
@@ -118,8 +118,18 @@ public class BackupSyncLargeMessageTest extends 
BackupSyncJournalTest {
       session.createQueue(QueueConfiguration.of(FailoverTestBase.ADDRESS));
       final ClientProducer producer = 
session.createProducer(FailoverTestBase.ADDRESS);
       final ClientMessage message = session.createMessage(true);
-      final int largeMessageSize = 1000 * MIN_LARGE_MESSAGE;
-      
message.setBodyInputStream(ActiveMQTestBase.createFakeLargeStream(largeMessageSize));
+
+      String largeBody;
+      {
+         String randomString = "large >>> " + RandomUtil.randomUUIDString() + 
" <<< ";
+         StringBuilder builder = new StringBuilder(randomString.length() * 
1000);
+         for (int i = 0; i < 1000; i++) {
+            builder.append(randomString);
+         }
+         largeBody = builder.toString();
+      }
+      message.getBodyBuffer().writeString(largeBody);
+
 
       final AtomicBoolean caughtException = new AtomicBoolean(false);
       final CountDownLatch latch = new CountDownLatch(1);
@@ -147,13 +157,12 @@ public class BackupSyncLargeMessageTest extends 
BackupSyncJournalTest {
 
       session.start();
       ClientConsumer consumer = 
session.createConsumer(FailoverTestBase.ADDRESS);
-      ClientMessage msg = consumer.receive(2000);
-      ActiveMQBuffer buffer = msg.getBodyBuffer();
+      ClientMessage largeMessageReceived = consumer.receive(2000);
+
+      ActiveMQBuffer readBuffer = largeMessageReceived.getBodyBuffer();
+      String readString = readBuffer.readString();
+      assertEquals(largeBody, readString);
 
-      for (int j = 0; j < largeMessageSize; j++) {
-         assertTrue(buffer.readable(), "large msg , expecting " + 
largeMessageSize + " bytes, got " + j);
-         assertEquals(ActiveMQTestBase.getSamplebyte(j), buffer.readByte(), 
"equal at " + j);
-      }
       receiveMessages(consumer, 0, 20, true);
       assertNull(consumer.receiveImmediate(), "there should be no more 
messages!");
       consumer.close();


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to